Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87188
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.49 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CAMUwpuQ5uCnic9PQTrzdg1=FLd_pthfuL_av49awtY7MYsER4A@mail.gmail.com>
References: <CAHMUw2GiRT6OFvrRiuCiikHF_tLu316wN9VG_pQ7vTXcXtJ40w@mail.gmail.com>
	<1436967838.8300.16.camel@kuechenschabe>
	<CAMUwpuQ5uCnic9PQTrzdg1=FLd_pthfuL_av49awtY7MYsER4A@mail.gmail.com>
Date: Wed, 15 Jul 2015 13:39:05 -0600
Message-ID: <CAFMT4NqN2M1iDd+x4LrtaisZdsffN9YGScazk0e-JG1xGNq8PQ@mail.gmail.com>
To: Julien Pauli <jpauli@php.net>
Cc: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>, 
	Tjerk Meesters <tjerk.meesters@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Consolidation of Traversable and array operations
From: levim@php.net (Levi Morrison)

On Wed, Jul 15, 2015 at 8:31 AM, Julien Pauli <jpauli@php.net> wrote:
> On Wed, Jul 15, 2015 at 3:43 PM, Johannes Schl=C3=BCter <johannes@schluet=
ers.de>
> wrote:
>
>> Hi,
>>
>> On Wed, 2015-07-15 at 11:28 +0000, Tjerk Meesters wrote:
>> > The most notable comment was that it would be nice to support Traversa=
ble
>> > as well as arrays; instead of only supporting this for my own function=
s,
>> > I've generalised this so that other functions can take advantage of th=
is
>> as
>> > well. These are the additions:
>> >
>> > 1. A ZPP argument; the "t" (for traversable) argument type has been ad=
ded
>> > that checks for either an array or implementation of zend_ce_traversab=
le.
>> >
>> > 2. A generic iteration function, called php_traverse(); it accepts:
>> >   a. the zval* to iterate over,
>> >   b. a step-wise function that receives the value and key, and returns=
 a
>> > boolean that determines whether iteration should continue or not,
>> >   c. a traversal mode (only values, or keys and values),
>> >   d. a context that's sent to the step-wise function.
>>
>> I really like this concept to unify by access pattern, hiding the actual
>> implementation!
>>
>> > 3. A concrete implementation of a step-wise iteration function,
>> >  php_traverse_until, that gets called as part of array_every() and
>> > array_some().
>>
>> I wonder if we can find a better naming scheme. For some array_
>> functions this will work, others not. This again feeds the "PHP is so
>> inconsistent"-trolls. At the moment I'm leaning towards simply using
>> every() and some_of() without reference to a type. Or maybe introduce,
>> to restart the namespace-debate, php\every(), php\search(), php
>> \someOf(), php\product(), etc. and deprecate array_search() etc.
>>
>> johannes
>>
>>
> Nikic designed "Iter" some time ago, when he finished adding Generators t=
o
> PHP.
> Perhaps some ideas could be taken from it.
> https://github.com/nikic/iter
>
> I suggest writing an RFC and target 8.0, while the deprecations could
> target 7.X
>
> Also, there has been an open subject for ages about how could we uniform
> array and Traversable internally, as well as from PHP user land (the main
> subject was then to add support for ArrayAccess to every array_***() PHP
> function).
>
> I'm happy this bumps the subject up , as it is quite a hot topic.

Do note that the union types RFC would also alleviate some of this
pain for user-land functions, since `array | Traversable` would cover
the required access pattern. I think this is a superior approach
myself, but I may be a bit biased as I am authoring that proposal:
https://wiki.php.net/rfc/union_types