Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87120
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <55A220D8.3090004@gmail.com>
References: <CAObuZdsA6T7uTCPignr_9g1bAbd83hsTrv9mAg7jU=oY96C9+Q@mail.gmail.com>
 <CALW=WECOo-JDWgHbmy=eUAVWCxt-0m_9sP-JeXe1hc0SokH37w@mail.gmail.com>
 <55A16375.4000707@php.net> <CAOsHV+sV2p7aBWOro=D5+xV+LZvNrt4Au3R3SqcJDy9qdPj8ig@mail.gmail.com>
 <55A220D8.3090004@gmail.com>
Date: Sun, 12 Jul 2015 13:16:53 -0300
Message-ID: <CAOsHV+tEjzAnG4ygRj1=0JgO4ps4AbWFQVHFex0+GuY44rdZbA@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: Sebastian Bergmann <sebastian@php.net>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] PHP7 and types
From: marcio.web2@gmail.com (Marcio Almada)

Stas,

2015-07-12 5:10 GMT-03:00 Stanislav Malyshev <smalyshev@gmail.com>:
> Hi!
>
>> Not completely bogus. At least with typed properties you won't need to
>> actually write the docblocks to have the IDE "hints". It's a minor win
>> for IDE users too.
>
> I don't see "not needing to write docblocks" as a win, quite the
> contrary.

Of course it's a win. Or do you like to write docblocks for every
single class property or method (even when the member is obvious) just
to have a "@var" so your IDE can work?

Not to mention you won't get any runtime/compile time check or
optimization from docblock tags, that's the main point of having typed
properties.

> In fact, in a number of projects I worked with, code without
> proper documentation (including docblocks) simply wasn't accepted into
> the repository.
>

If you are using the term "proper documentation" to justify docblocks
everywhere even if they contain just a "/** @var string */", it's a
sign we've been using comments against us all this time (even if we
called it "doc comments").

But thankfully we are moving PHP to another direction. Do you remember
the "return types" voting results?
https://wiki.php.net/rfc/return_types#vote. That's because "function()
: type" is self documented and much more maintainable than than a
possibly sloppy "/** @return type */" on top of every method on a
codebase.

> While I don't think this needs to be mandatory, I also don't see major
> difference - so you have to write type instead of docblock, you still
> have to write something.
>

But with the benefits already cited above. Docblocks should not be a
place for type information anymore, this was a workaround and we've
been slowly replacing it with a better solution (opt in types).
Property types seems to be the next logical step after adding return
types and scalar types.

> --
> Stas Malyshev
> smalyshev@gmail.com

Is there any technical reason for you to be against typed properties?
IMMO, just arguing against opt in type declarations (evolving the php
type system) in favor of docblocks (stagnation) seems to be utterly
unproductive as we already know the tendencies from previous votings.

Marcio