Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87080
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.53 as permitted sender)
Message-ID: <559D7DE1.8000603@gmail.com>
Date: Wed, 08 Jul 2015 12:45:37 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Net Mo <netmo.php@gmail.com>, internals@lists.php.net
References: <CAOv67gvxRZ0e7RBKbSsnZdGz4YDCbE8jNm4ULat4+A3vus7z8Q@mail.gmail.com>
In-Reply-To: <CAOv67gvxRZ0e7RBKbSsnZdGz4YDCbE8jNm4ULat4+A3vus7z8Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Change IntlChar::getNumericValue() to return something
 less horrible when the char is not numeric?
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> ICU documentation:
> http://icu-project.org/apiref/icu4c/uchar_8h.html#a36982efc84143b9bb5a11bf54b86af48
> 
> Currently the PHP function returns the U_NO_NUMERIC_VALUE constant, which
> is set to the very weird "float(-123456789)"; basically it's a value that
> it's certain it doesn't have an Unicode numeric character equivalent
> counterpart.
> 
> I would change the function to return NULL instead; what do you think?

While the exact value of U_NO_NUMERIC_VALUE looks weird, nobody is going
to use it directly, you'd be using U_NO_NUMERIC_VALUE. Comparing to it
doesn't look wrong. So changing that to null doesn't seem to improve
much, just introduce incompatibility with ICU.

-- 
Stas Malyshev
smalyshev@gmail.com