Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87070
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAKws9z11MeHNj6A2RyWV6gXve693yJYO+c-0Fbs79M-CXMXbng@mail.gmail.com>
References: <CAKws9z11MeHNj6A2RyWV6gXve693yJYO+c-0Fbs79M-CXMXbng@mail.gmail.com>
Date: Wed, 8 Jul 2015 12:03:36 +0200
Message-ID: <CAF+90c-NgVO1r0C_AXmdbK6Fh1fcqe6nS9ebXqW5z01GhwVdjw@mail.gmail.com>
To: Scott Arciszewski <scott@paragonie.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1135e3989e5380051a5a4069
Subject: Re: [PHP-DEV] random_compat
From: nikita.ppv@gmail.com (Nikita Popov)

--001a1135e3989e5380051a5a4069
Content-Type: text/plain; charset=UTF-8

On Wed, Jul 8, 2015 at 11:59 AM, Scott Arciszewski <scott@paragonie.com>
wrote:

> Hi everyone,
>
> I'm working on a library to backport random_bytes() and random_int()
> into PHP 5. The effort is located on Github if anyone is interested:
> https://github.com/paragonie/random_compat
>
> My reason for this email is that I'm running into one compatibility
> issue that I don't think I can safely work around: If we let
> random_int() default to -PHP_INT_MAX and PHP_INT_MAX, then the
> difference between the two (used to calculate the range) will overflow
> into a float, which will lead to a loss of precision.
>
> My current compromise is to use -(PHP_INT_MAX/2) and PHP_INT_MAX/2,
> but I'm not sure if there's a better solution.
>

random_int() arguments don't have default values, you have to explicitly
pass both. (Of course you still have a problem if someone does pass them :)

Nikita

--001a1135e3989e5380051a5a4069--