Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87047
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain hotmail.com designates 65.55.111.164 as permitted sender)
Message-ID: <BLU437-SMTP10AE3C0D27EFC702B83C04E2930@phx.gbl>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
In-Reply-To: <0ca201d0b7d3$72697240$573c56c0$@belski.net>
Date: Mon, 6 Jul 2015 14:59:12 +0200
CC: Aaron Piotrowski <aaron@icicle.io>,
 internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
References: <7D73A3C7-F694-497B-9A9D-4F375F86B6A0@icicle.io> <0ca201d0b7d3$72697240$573c56c0$@belski.net>
To: Anatol Belski <anatol.php@belski.net>
Subject: Re: [PHP-DEV] Error Subclasses
From: bobwei9@hotmail.com (Bob Weinand)

Hey Anatol

> Am 06.07.2015 um 12:06 schrieb Anatol Belski <anatol.php@belski.net>:
>=20
> Hi Aaron,
>=20
>> -----Original Message-----
>> From: Aaron Piotrowski [mailto:aaron@icicle.io]
>> Sent: Monday, July 6, 2015 8:16 AM
>> To: internals@lists.php.net
>> Subject: [PHP-DEV] Error Subclasses
>>=20
>> Hello everyone!
>>=20
>> I recently pushed changes that eliminated E_EXCEPTION and allows an
>> exception type to be provided for what were fatals in PHP, while =
still falling back
>> to an E_ERROR if necessary.
>>=20
>> Since more specific Error classes can be thrown, I'd like to propose =
the following
>> additions to the Error tree of exceptions: AccessError and =
IdentifierError.
>>=20
>> AccessError - Thrown when trying attempting to call a public, =
private, or
>> abstract method, when statically calling a non-static method, or =
trying to use
>> self::, parent::, or static:: outside of a class.
>> IdentifierError - Thrown when referencing an undefined function, =
method, class,
>> constant, etc.
>>=20
>> I=E2=80=99ve created a patch that implements the exceptions above as =
well as updating
>> all the related tests: =
https://github.com/trowski/php-src/tree/error-subclasses
>> <https://github.com/trowski/php-src/tree/error-subclasses>
>>=20
>> This patch also broadens the usage of TypeError to include conditions =
such as
>> calling a method on a scalar, passing a value that does not specify a =
callback
>> when one is expected, and various other conditions based on an =
incorrect type
>> that otherwise are throwing plain Error objects.
>>=20
>> This patch introduces no functional changes, only more specific types =
of Errors
>> are thrown from conditions that were already throwing Error objects.
>>=20
>> I was hoping this could be merged before beta 1, though I=E2=80=99m =
not sure if the time
>> table is too tight.
>>=20
> Thanks for the ping. While I find the idea about more specific =
exceptions correct, I would not recommend merging it in beta1. Reason - =
we have no big time now to verify the patch completeness, to discuss the =
exception names and areas where it's applicable.
>=20
> IMHO if it goes in, it has to be complete and well verified, maybe =
also voted (regarding namings). As the area is very public and if we =
find any issues later and have to rename/rework the exception names, =
etc. - it would be bad. So 7.1 might be a better place to target. =
Technically it would be anyway worky as those specialized extension =
classes will have the same parent.
>=20
> Regards
>=20
> Anatol

I like what Aaron did here.

I really think that should target 7.0. It's actually not breaking =
anything (really just changing the exception names).
And I really think we should have a proper Error hierarchy at the =
release of PHP 7.0. Considering it especially one of *the* features of =
7.0.

But I think, at end of beta 2 or so, we really should do a final review =
of all the Errors in order to ensure everything is aptly named and used.

Bob=