Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87046
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: =?UTF-8?Q?'C=C3=B4me_BERNIGAUD'?= <come.bernigaud@opensides.be>,
	"'Andreas Heigl'" <andreas@heigl.org>,
	"'PHP internals'" <internals@lists.php.net>
References: <5598F64E.4040501@gmail.com> <55996336.7000104@opensides.be> <55997B82.2080307@heigl.org> <559A2B35.2050809@opensides.be> <559A3846.3010304@heigl.org> <559A3922.4010807@opensides.be> <559A3E01.4090403@heigl.org> <559A3FF0.4070107@opensides.be>
In-Reply-To: <559A3FF0.4070107@opensides.be>
Date: Mon, 6 Jul 2015 13:13:35 +0200
Message-ID: <0cdd01d0b7dc$cf49c1f0$6ddd45d0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHV1+5JE37FBu7+6g8MqQVgOZFDeAH3VvDeAhy8xHgCUC+HpAHphYejAVipC6sBTfQ4oABJwFwYnWoYIQA=
Content-Language: en-us
Subject: RE: [PHP-DEV] Re: LDAP build broken
From: anatol.php@belski.net ("Anatol Belski")

Hi Come,

> -----Original Message-----
> From: C=C3=B4me BERNIGAUD [mailto:come.bernigaud@opensides.be]
> Sent: Monday, July 6, 2015 10:45 AM
> To: Andreas Heigl; PHP internals
> Subject: Re: [PHP-DEV] Re: LDAP build broken
>=20
> On 2015-07-06 10:36, Andreas Heigl wrote:
> > Am 06.07.15 um 10:15 schrieb C=C3=B4me BERNIGAUD:
> >> Possibilities are:
> >> - Add a test in the configure for this method and disable if =
it=E2=80=99s not
> >> there, tell Mac users to get a real openldap.
> >
> > That might be the best solution but I think it's not really =
practical.
> > Even the brew-installation (currently) uses the internal =
LDAP-library.
>=20
> I agree this would be ideal but seems kind of harsh for Mac users
>=20
> >> - Add the same kind of test but set a define with it and add ifdefs
> >> in the code to use ldap_find_control instead
> >> - Add the same test but in the ifdef declare an ldap_control_find
> >> method which calls ldap_find_control.
> >
> > This sounds like the best solution to it. At least as long as the =
two
> > functions are interchangeable. From a first glance at the code I've
> > seen that the function-signature is different of the both, but I =
don't
> > know whether that can be overcome.
> >
> > Going this way would mean that the code change is concentrated on =
one
> > place (as far as I see it) which would make it easier to maintain.
> > Otherwise we'd have multiple ifdefs scattered arouond the =
source-code.
> > Or did I missinterpret that?
>=20
> Yeah, this was the idea, concentrating the changes in one place.
> I=E2=80=99m gonna check if it=E2=80=99s easy to implement.
I've also another symbol error with today's master

/usr/bin/ld.bfd.real: ext/ldap/.libs/ldap.o: undefined reference to =
symbol 'ber_scanf@@OPENLDAP_2.4_2'
/usr/lib/x86_64-linux-gnu/liblber-2.4.so.2: error adding symbols: DSO =
missing from command line

On
cat /etc/issue
Ubuntu 14.04.2 LTS \n \l

Probably should be added to the configure checks as well.

Regards

Anatol