Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:87044 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 64998 invoked from network); 6 Jul 2015 08:48:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Jul 2015 08:48:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=come.bernigaud@opensides.be; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=come.bernigaud@opensides.be; sender-id=pass Received-SPF: pass (pb1.pair.com: domain opensides.be designates 195.154.20.141 as permitted sender) X-PHP-List-Original-Sender: come.bernigaud@opensides.be X-Host-Fingerprint: 195.154.20.141 unknown Received: from [195.154.20.141] ([195.154.20.141:48468] helo=smtp.opensides.be) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A5/B9-21549-0F04A955 for ; Mon, 06 Jul 2015 04:48:50 -0400 Received: from localhost (localhost [127.0.0.1]) by smtp.opensides.be (Postfix) with ESMTP id 9612575899; Mon, 6 Jul 2015 10:48:46 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at opensides.be Received: from smtp.opensides.be ([127.0.0.1]) by localhost (smtp.opensides.be [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zJMwLONJ6Ge8; Mon, 6 Jul 2015 10:48:46 +0200 (CEST) Received: from [192.168.0.20] (den69-1-88-181-232-26.fbx.proxad.net [88.181.232.26]) by smtp.opensides.be (Postfix) with ESMTPSA id 037EA75886; Mon, 6 Jul 2015 10:48:45 +0200 (CEST) Message-ID: <559A3FF0.4070107@opensides.be> Date: Mon, 06 Jul 2015 10:44:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Andreas Heigl , PHP internals References: <5598F64E.4040501@gmail.com> <55996336.7000104@opensides.be> <55997B82.2080307@heigl.org> <559A2B35.2050809@opensides.be> <559A3846.3010304@heigl.org> <559A3922.4010807@opensides.be> <559A3E01.4090403@heigl.org> In-Reply-To: <559A3E01.4090403@heigl.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bh5oKQ0cnUrpGEnbdhpLXBuoKR9jpfH6M" Subject: Re: [PHP-DEV] Re: LDAP build broken From: come.bernigaud@opensides.be (=?UTF-8?B?Q8O0bWUgQkVSTklHQVVE?=) --bh5oKQ0cnUrpGEnbdhpLXBuoKR9jpfH6M Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2015-07-06 10:36, Andreas Heigl wrote: > Am 06.07.15 um 10:15 schrieb C=C3=B4me BERNIGAUD: >> Possibilities are: >> - Add a test in the configure for this method and disable if it=E2=80=99= s not >> there, tell Mac users to get a real openldap. > > That might be the best solution but I think it's not really practical. > Even the brew-installation (currently) uses the internal LDAP-library. I agree this would be ideal but seems kind of harsh for Mac users >> - Add the same kind of test but set a define with it and add ifdefs in= >> the code to use ldap_find_control instead >> - Add the same test but in the ifdef declare an ldap_control_find meth= od >> which calls ldap_find_control. > > This sounds like the best solution to it. At least as long as the two > functions are interchangeable. From a first glance at the code I've see= n > that the function-signature is different of the both, but I don't know > whether that can be overcome. > > Going this way would mean that the code change is concentrated on one > place (as far as I see it) which would make it easier to maintain. > Otherwise we'd have multiple ifdefs scattered arouond the source-code. > Or did I missinterpret that? Yeah, this was the idea, concentrating the changes in one place. I=E2=80=99m gonna check if it=E2=80=99s easy to implement. --bh5oKQ0cnUrpGEnbdhpLXBuoKR9jpfH6M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJVmj/wAAoJEKhk2MPOyw4AhjEP/1xarO2GXKM0yqaoD1yz4Tmr V5V9UOM0VzE3pWeR8kEHKx2mSr88L14aAeDQKwpG5vtHGEebetXUDGBTxQwy9+iM p8QMdIm1UC+dJzisetDWJKvBSJVu5+8kBI+7kzTXtf7FN5XYP0Gzy74rejxvGwmd +q/w59tA46bdiC5dozmuNPiSUPngiRTEfacP8oIb8hQyGoqfRnz7AALjc2TdCLid w9pchKDNShIZLakpNGonQPuM4RwuUG/NWIR2TradndKkwNtxnP/6e9YKtYt7rjrM ooh6n1lyiMB5Mdxy7t3vET+tMJepG+LvRY2waAHRATJKzKPdkD/Kl3u6Z+DHhJIu WhS8i0y6GbSY+jyKWYmnpMjsqmGOZlx8iLcG7QgsYtOst2BoEvAe7GFPi7rafGbu KKzuH4OUpkfXx0cpVP69PEhPkuxYp6FJwOHzuy0MMvVIyY0DNt69pugxHvHD+CC1 V1ioKIpzl25OGI6SRuef9Vnx+LVI3BeFZ2VePyYfUMw6+Hlq0cWTh3u6OjHpUXch rIjuWyb7LJvCrgbTqWDOAQmi+P4+nqqCmIX6jWyYroRSdK+7qey1SRKEULO5/qXz wYcsaR+LiMHOJznH/Ju1d9SdYnjPWilZSMFcK8j2UWNFPrLlEzAZlcQx0EhulIJN 3Ihan2UBkay/o80frcPh =ZbT5 -----END PGP SIGNATURE----- --bh5oKQ0cnUrpGEnbdhpLXBuoKR9jpfH6M--