Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87030
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Ferenc Kovacs'" <tyra3l@gmail.com>,
	"'Sherif Ramadan'" <theanomaly.is@gmail.com>
Cc: "'Dan Ackroyd'" <danack@basereality.com>,
	=?UTF-8?Q?'Jakub_Kub=C3=AD=C4=8Dek'?= <kelerest123@gmail.com>,
	"'Dmitry Stogov'" <dmitry@zend.com>,
	"'Bob Weinand'" <bobwei9@hotmail.com>,
	"'Andrea Faulds'" <ajf@ajf.me>,
	"'PHP Internals'" <internals@lists.php.net>,
	"'Nikita Popov'" <nikita.ppv@gmail.com>,
	"'Aaron Piotrowski'" <aaron@icicle.io>,
	"'Levi Morrison'" <levim@php.net>,
	"'Kalle Sommer Nielsen'" <kalle@php.net>
References: <CA+kxMuRg1PvRAVnxZsZd2uFeTHfBoWzKvOqFMqFfGq2SVZUkJg@mail.gmail.com>	<CAL+t6cGgE-5hT-bs7gN-cJ4Eoood7keK7FHDwHaE_=J_3RC+Ag@mail.gmail.com> <CAH-PCH5ObfF57RihMQRtrt3HL9uUSGxaFapK8i6KGmfMHgTNwA@mail.gmail.com>
In-Reply-To: <CAH-PCH5ObfF57RihMQRtrt3HL9uUSGxaFapK8i6KGmfMHgTNwA@mail.gmail.com>
Date: Sun, 5 Jul 2015 20:44:45 +0200
Message-ID: <0b1b01d0b752$ac7da0e0$0578e2a0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQKVzYbufkWfCOae7USYfaVRsIOd2AIG1ihCAU5/2mScKFhxQA==
Content-Language: en-us
Subject: RE: [PHP-DEV] Re: Revert unapproved language change, was: Fix division by zero to throw exception (round 2)
From: anatol.php@belski.net ("Anatol Belski")

Hi,

> -----Original Message-----
> From: Ferenc Kovacs [mailto:tyra3l@gmail.com]
> Sent: Sunday, July 5, 2015 7:02 PM
> To: Sherif Ramadan
> Cc: Dan Ackroyd; Jakub Kub=C3=AD=C4=8Dek; Dmitry Stogov; Bob Weinand; =
Andrea Faulds;
> PHP Internals; Nikita Popov; Aaron Piotrowski; Levi Morrison
> Subject: Re: [PHP-DEV] Re: Revert unapproved language change, was: Fix
> division by zero to throw exception (round 2)
>=20
> On Sun, Jul 5, 2015 at 1:01 PM, Sherif Ramadan =
<theanomaly.is@gmail.com>
> wrote:
>=20
> > On Sun, Jul 5, 2015 at 6:29 AM, Dan Ackroyd <danack@basereality.com>
> > wrote:
> >
> > > On 4 July 2015 at 20:56, Sherif Ramadan <theanomaly.is@gmail.com>
> wrote:
> > > >
> > > > I'm proposing that we reconsider removing the warning from
> > > > floating
> > point
> > > > division and here's why.
> > >
> > > Wait ....what? I don't remember an RFC about the behaviour =
changing.
> > > Did someone ninja commit a change to the language?
> > >
> > > Well it sure looks like it:
> > >
> > >
> > https://github.com/php/php-
> src/commit/f9724b93f6592d2f77fa9165038a0ba0
> > db3da0c6
> > >
> > > This is absolutely a change that needs an RFC. As the change was
> > > done without one, please can it be reverted until an RFC is done?
> > >
> >
> > I actually fully agree to the IEEE 754 compliance part and I doubt
> > anyone will disagree on that part as it only stands to benefit
> > everyone. However, I completely disagree with removing the warning
> > blind-sidedly and especially two days before the beta1 release like
> > that. I do opt that it be reverted, however, until the matter is =
fully
> > resolved. If that happens to take a day or a month it shouldn't =
result
> > in releasing ad hoc changes that will be wish-washy between releases
> > like that should something change. At the very least let's cherry =
pick
> > it out of the beta 1 release to ensure we've fully resolved the =
matter.
> >
> >
> hi,
>=20
> my 2 cents:
> the IEEE 754 related changes had enough discussion and while it would =
have
> been nice handling it under an rfc earlier instead of pushing it late =
calling it a
> bugfix I think we should keep it.
> however I see little point in removing the warning at this point, I =
can understand
> how from a purist point of view it makes little sense, but we have =
this warning
> forever and as people already pointed out at the very least can help =
with
> debugging bugs in your code.
> so I would keep the warning for 7.0 (as removing it after beta1 would =
be even
> worse than pushing the change 2 days before tagging beta1).
>=20
The related changes are reverted as breaching BC. The issue reported by =
Dan is likely to prevent people from catching errors the ways they do it =
in PHP5. Furthermore, it's likely to break apps or make them misbehave. =
This is something we can't bear so short before beta1.

Bob, I would kindly ask you again to not to commit such controversial =
changes without having a clear OK from the community. As for me - IMHO, =
the proper solution could be your first commit introducing exceptions =
for all (as in many other programming languages for div by zero) - but =
it was a BC breach as well, timed too short before feature freeze. So it =
is something that clearly needs an RFC to evaluate any possible risks =
and to make an informed collective decision. Many things are not perfect =
yet even in PHP7, but we have our timeline plan on which you was voting, =
too.

Thanks

Anatol