Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87026
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.160.174 cause and error)
MIME-Version: 1.0
Date: Sun, 5 Jul 2015 10:29:38 +0000
Message-ID: <CA+kxMuRg1PvRAVnxZsZd2uFeTHfBoWzKvOqFMqFfGq2SVZUkJg@mail.gmail.com>
To: Sherif Ramadan <theanomaly.is@gmail.com>
Cc: =?UTF-8?B?SmFrdWIgS3Viw63EjWVr?= <kelerest123@gmail.com>, 
	Dmitry Stogov <dmitry@zend.com>, Bob Weinand <bobwei9@hotmail.com>, Andrea Faulds <ajf@ajf.me>, 
	PHP Internals <internals@lists.php.net>, Nikita Popov <nikita.ppv@gmail.com>, 
	Aaron Piotrowski <aaron@icicle.io>, Levi Morrison <levim@php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Revert unapproved language change, was: Fix division by zero to throw
 exception (round 2)
From: danack@basereality.com (Dan Ackroyd)

On 4 July 2015 at 20:56, Sherif Ramadan <theanomaly.is@gmail.com> wrote:
>
> I'm proposing that we reconsider removing the warning from floating point
> division and here's why.

Wait ....what? I don't remember an RFC about the behaviour changing.
Did someone ninja commit a change to the language?

Well it sure looks like it:
https://github.com/php/php-src/commit/f9724b93f6592d2f77fa9165038a0ba0db3da=
0c6

This is absolutely a change that needs an RFC. As the change was done
without one, please can it be reverted until an RFC is done?

Bob Weinand wrote:
> I=E2=80=99m just saying that warning in the worst we can have.

You are wrong; it allows:

* People who want it to be an exception to convert it to an exception
in their error handler.
* People who want to ignore it can suppress it with the squelch operator.
* People who want to handle it on a case by case basis in their code can do=
.

This is another case where you are ignoring other people's use-cases,
and imagining that your use-case is the only valid use-case.

But the technical discussion is one that we should have when someone
is proposing this change - not when someone has committed it first and
then is asking for approval.

cheers
Dan