Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87003
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Philip Hofstetter'" <phofstetter@sensational.ch>,
	"'PHP internals'" <internals@lists.php.net>
References: <CAGKNXQGLrpgT7DrcLmp9pTAbK53bRiaaF6w5ZoYNSz5qY-=w_A@mail.gmail.com>
In-Reply-To: <CAGKNXQGLrpgT7DrcLmp9pTAbK53bRiaaF6w5ZoYNSz5qY-=w_A@mail.gmail.com>
Date: Thu, 2 Jul 2015 16:51:17 +0200
Message-ID: <07c501d0b4d6$8f446690$adcd33b0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHpxBZHfAqKSNVigXb8gPhcoTVKj52WIxBQ
Content-Language: en-us
Subject: RE: [PHP-DEV] date extension / Type Hinting
From: anatol.php@belski.net ("Anatol Belski")

Hi Philip,

> -----Original Message-----
> From: Philip Hofstetter [mailto:phofstetter@sensational.ch]
> Sent: Thursday, July 2, 2015 3:35 PM
> To: PHP internals
> Subject: [PHP-DEV] date extension / Type Hinting
>=20
> Hi,
>=20
> as this probably requires some discussion, I'm coming here to ask.
>=20
> I'm talking about bug 69977 and 61483: Both are about the fact that =
it's
> currently not possible to properly type-hint descendant classes of =
DateTime and
> friends.
>=20
> The reason is the missing use ZEND_ARG_OBJ_INFO, so right now, users =
can
> only create descendant classes without any type hinting on their =
methods.
>=20
> Adding the ZEND_ARG_OBJ_INFO is quite trivial and in-fact, I have a =
branch here
> that does it:
>=20
> https://github.com/pilif/php-src/tree/bug-69977
>=20
> Of course this is going to break a whole lot of tests because what was =
once
> warnings is now a TypeError.
>=20
> I'd be willing to update all the tests as needed, but of course =
changing the
> behaviour like this is a BC issue in itself, hence I'm coming here.
>=20
> The reason why I think this matters much more now than back when 61483 =
was
> submitted is two-fold:
>=20
> 1) back in 61483, adding the (correct!) type-hints was "just" causing =
an E_STRICT
> message. But now with PHP7 it's actually an E_WARNING. So people =
running
> without E_STRICT enjoyed correct type hints until now which they now =
can't any
> more (so, there's another BC break right there :p)
> 2) With PHP7 type hinting becomes much more viable, so forcing users =
to not
> type-hint something that really should be feels kind of ugly.
> 3) Having a new major release is as good a time as any for chaning the
> behaviour, especially when the change is related to a major new =
feature (the
> addition of much stricter typing).
>=20
> So I'm asking for opinions on what should be done here.
>=20
> Again: If you lean /at all/ in the direction of changing this, I =
volunteer to update
> all the tests as required.
please read this thread for more info =
https://github.com/php/php-src/commit/8e19705a93d785cd1ff8ba3a69699b00169=
fea47 .=20

Regards

Anatol