Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:870
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Fri, 11 Apr 2003 21:23:19 +0200
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v551)
Cc: Harrie Hazewinkel <harrie@php.net>,
 Johann Hanne <jonny@1409.org>
To: internals@lists.php.net
Content-Transfer-Encoding: 7bit
Message-ID: <0DB1638C-6C53-11D7-BC08-0003934A5A7E@php.net>
Subject: RE: [PHP-DEV] [PATCH] SNMP value retrieval
From: harrie@php.net (Harrie Hazewinkel)

HI,

Jonny, it your personal email address is bouncing.
That you know (maybe even the mailinglist email bounces for you).

I have looked at your patch and tested it. Seem OK.
some questions and changes I would like you feedback on below.


On Tuesday, January 14, 2003, at 08:19 PM, Johann Hanne wrote:

>
> Hi,
>
> as promised I've created a patch which adds some functionality to the
> SNMP module. It's controlled with a new function named
> snmp_set_valuemethod(int method) which changes the way how SNMP values
> are returned by snmpget(), snmpwalk() and snmpwalkoid(). The following
> (new) constants can be passed to snmp_set_valuemethod():
> - SNMP_VALUEMETHOD_LIBRARY:
> - SNMP_VALUEMETHOD_PLAIN:
> - SNMP_VALUEMETHOD_OBJECT:

Do these names to be so long?? I was thinking we cane drop the
'VALUEMETHOD' or 'METHOD' part. Would that be OK and which do
you prefer??


>  the value type returned by the SNMP
>   agent (the ASN_* constants from the net-snmp library are also
>   defined as PHP constants)

I believe the ASN_ prefix should be SNMP_ and changed as such.
That they are internally ASN_ does not matter.

ANother thing I would like to ask is whether the group wants to support
also all kinds of types of SNMP that are not standardized and somehow
added to NET-SNMP as an expiriment.
I believe it is better to drop those, what do you think??


Harrie



Harrie