Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86994
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.223.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <BLU436-SMTP69FBA3B51DA1D27C3A73A4E2970@phx.gbl>
References: <CA+9eiLvd0YPKtED9CgU_thC9HUfTquaMJNf_9zQC0jyeX+rTuw@mail.gmail.com>
	<33BCE1D0-BA6D-464C-B23D-69AF71356111@ajf.me>
	<CA+9eiLsEDb-GuP4pRi-C8GQ2N+q7K=f-gmUMMxzxyy54CDy67w@mail.gmail.com>
	<3932E76B-DC75-40CD-8B1A-B84F387707CC@ajf.me>
	<CA+9eiLt3ScjNDuYLW=fLY2BUepzcRz=XPxbQCjSoy++0p67YNw@mail.gmail.com>
	<BLU437-SMTP1001E15E94ACA9AEE4676D6E2AA0@phx.gbl>
	<B4ACC432-714A-478B-9E1B-C9C532710598@ajf.me>
	<BLU436-SMTP121ED71E7D26AD9D99D9668E2AA0@phx.gbl>
	<1EFE20ED-ED80-47D1-B697-58CA4359CA62@ajf.me>
	<BLU436-SMTP69FBA3B51DA1D27C3A73A4E2970@phx.gbl>
Date: Thu, 2 Jul 2015 10:59:06 +0300
Message-ID: <CA+9eiLtZb+VNLNb_i0F+GfobroxffT50Sj564L64GSYmnRR2Sg@mail.gmail.com>
To: Bob Weinand <bobwei9@hotmail.com>
Cc: Andrea Faulds <ajf@ajf.me>, PHP Internals <internals@lists.php.net>, 
	Nikita Popov <nikita.ppv@gmail.com>, Aaron Piotrowski <aaron@icicle.io>, Levi Morrison <levim@php.net>
Content-Type: multipart/alternative; boundary=001a113f25dc48eaff0519dfd0f4
Subject: Re: [PHP-DEV] Fix division by zero to throw exception (round 2)
From: dmitry@zend.com (Dmitry Stogov)

--001a113f25dc48eaff0519dfd0f4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 2, 2015 at 3:26 AM, Bob Weinand <bobwei9@hotmail.com> wrote:

> > Am 29.06.2015 um 19:14 schrieb Andrea Faulds <ajf@ajf.me>:
> >
> > Hi again,
> >
> >> On 29 Jun 2015, at 18:02, Bob Weinand <bobwei9@hotmail.com> wrote:
> >>
> >> Yes, it generally makes sense...
> >> Then I have other questions:
> >>
> >> - Why do we then still have a Warning? Either we have well-defined
> behavior, or we throw an exception. Well-defined behavior *plus* a warnin=
g
> is IMO non-sense.
> >
> > That=E2=80=99s weird, yeah. We don=E2=80=99t throw warnings for the mat=
h functions when
> you give them odd inputs, e.g. sin(INF) is just NAN, no warning.
> >
> > I think removing it would make sense.
> >
> >> - Is it intentional for intdiv and % to throw an Exception instead of
> Error or some more specific DivisionByZeroError or similar? (yes, I know,
> Error is only very recent, but the question still needs to be asked).
> >
> > Hmm. Using Error might make some sense given it used to raise E_WARNING=
.
> I think DivisionByZeroError sounds like a good idea.
>
> Hey,
>
> I just committed that to master=E2=80=A6
>
> But I noticed that intdiv(PHP_INT_MIN, -1) isn't very well suited for a
> DivisionByZeroError.
>
> What do you think about adding an ArithmeticError for that case (and
> making DivisionByZeroError subclass of it)?
> That ArithmeticError could then be reused for negative bitshifts, which
> would solve the question what to do with that too.
>

I think we should introduce ArithmeticError, as you propose.

Thanks. Dmitry.


>
> Thanks,
> Bob

--001a113f25dc48eaff0519dfd0f4--