Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86978
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Dmitry Stogov'" <dmitry@zend.com>
Cc: "'PHP Internals'" <internals@lists.php.net>,
	"'Pierre Joye'" <pierre.php@gmail.com>,
	"'Kalle Sommer Nielsen'" <kalle@php.net>,
	"'Xinchen Hui'" <laruence@php.net>,
	"'Nikita Popov'" <nikita.ppv@gmail.com>
References: <055b01d0b364$5414b890$fc3e29b0$@belski.net> <CA+9eiLseEjtyHYtoTv8WUMAHk9_xW1MkzSexJVa4FnknKPOqag@mail.gmail.com>
In-Reply-To: <CA+9eiLseEjtyHYtoTv8WUMAHk9_xW1MkzSexJVa4FnknKPOqag@mail.gmail.com>
Date: Tue, 30 Jun 2015 23:00:50 +0200
Message-ID: <056b01d0b377$dad4e590$907eb0b0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHdK+UcnwgdqR38ERSGNmq98XKlbwGRXFNGnaAMZwA=
Content-Language: en-us
Subject: RE: [PHP-DEV] Re: Fixes for #69900 and #69963
From: anatol.php@belski.net ("Anatol Belski")

Hi Dmitry,

Thanks for the review :)

Greetings

Anatol

> -----Original Message-----
> From: Dmitry Stogov [mailto:dmitry@zend.com]
> Sent: Tuesday, June 30, 2015 9:45 PM
> To: Anatol Belski
> Cc: PHP Internals; Pierre Joye; Kalle Sommer Nielsen; Xinchen Hui; =
Nikita Popov
> Subject: [PHP-DEV] Re: Fixes for #69900 and #69963
>=20
> Hi Anatol,
>=20
> I don't see any problems committing this.
>=20
> Thanks. Dmitry.
>=20
>=20
> On Tue, Jun 30, 2015 at 9:41 PM, Anatol Belski <anatol.php@belski.net>
> wrote:
>=20
> > Hi,
> >
> > regarding the mentioned tickets I've prepared a patch
> > =
https://github.com/php/php-src/compare/master...weltling:pipe_blocking
> > _win
> > .
> > Anonymous pipes on Windows
> >
> > - don't support asynchronous IO
> > - don't support select()
> > - have buffer size of 4096 bytes (or even less) which is much easier
> > overflown that a buffer of 64kb often to be seen on Unix
> >
> > These issues was addressed last year, but the tickets mentioned =
report
> > about the issues still persisting in PHP5/7. While it's likely a no =
go
> > for PHP5, I would like to push this patch into PHP7. Particularly =
what
> > it does is allowing the blocking read() again for the edge cases
> > reported in the listed tickets. It is done adding a context option =
and
> > a new win only option for proc_open. Just to illustrate a few -
> >
> > =3D=3D=3D=3D SNIPPET =3D=3D=3D=3D
> > /* here proc_open() will do a blocking read on the child process*/
> > $process =3D proc_open(PHP_BINARY.' -f ' . $fl, $descriptorspec, =
$pipes,
> > NULL, NULL, array("blocking_pipes" =3D> true)); =3D=3D=3D=3D END =
SNIPPET =3D=3D=3D=3D
> >
> > =3D=3D=3D=3D SNIPPET =3D=3D=3D=3D
> > $in =3D fopen("php://stdin", "rb", false, =
stream_context_create(array("pipe"
> > =3D> array("blocking" =3D> true))));
> > +while(!feof($in)){ /* here feof() will do a blocking read on the =
pipe
> > +*/
> > ........................
> > =3D=3D=3D=3D END SNIPPET =3D=3D=3D=3D
> >
> > The only drawback on this is that blocking reads on pipes are likely
> > to cause pipe buffer overflows and thus deadlock, like it was =
before.
> > Though, when working with them carefully, this could be avoided and
> > would bring improvements with several edge cases, almost when =
working
> > on CLI. Anyway this patch brings no difference to PHP5 while =
addressing those
> edge cases.
> >
> > I would like to ask for review here. I've also made a minimal build
> > with this patch http://windows.php.net/downloads/snaps/ostc/69900/ =
for
> > those interested to test. If there are no strong objections, it =
should
> > be merged soon.
> >
> > Thanks
> >
> > Anatol
> >
> >