Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86974
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fredemmott.co.uk from 209.85.220.54 cause and error)
Content-Type: multipart/alternative; boundary="Apple-Mail=_5CA35980-C30A-4F7C-9848-9B478EB58FE2"
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
In-Reply-To: <CAHvhOfi+BDPz3xSAM75AGraUH3y14J56yh773ef1VApbViwjTA@mail.gmail.com>
Date: Tue, 30 Jun 2015 10:10:03 -0700
Cc: Florian Anderiasch <ml@anderiasch.de>,
 Yasuo Ohgaki <yohgaki@ohgaki.net>,
 Christian Schneider <cschneid@cschneid.com>,
 PHP Development <internals@lists.php.net>
Message-ID: <3EC41B94-9B8E-4894-86C3-1D922D8E0A20@fredemmott.co.uk>
References: <68262FAD-587B-47FF-B388-3B8551FDCA22@cschneid.com> <CAGa2bXakGj+iJTCFVv8Pjwy_KbrfKEJH42bapVgrQr8BqBAMnQ@mail.gmail.com> <5582FCE8.9070108@anderiasch.de> <CAHvhOfi+BDPz3xSAM75AGraUH3y14J56yh773ef1VApbViwjTA@mail.gmail.com>
To: =?utf-8?Q?Jakub_Kub=C3=AD=C4=8Dek?= <kelerest123@gmail.com>
Subject: Re: [PHP-DEV] Revisit trailing commas in function call parameters?
From: fred@fredemmott.co.uk (Fred Emmott)

--Apple-Mail=_5CA35980-C30A-4F7C-9848-9B478EB58FE2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Some more context:

https://bugs.php.net/bug.php?id=3D64176 =
<https://bugs.php.net/bug.php?id=3D64176>
https://wiki.php.net/rfc/trailing-comma-function-args =
<https://wiki.php.net/rfc/trailing-comma-function-args> (failed 15-20)

On a more positive side, this change was very well received within =
Facebook when implemented within HHVM; this was a mix of:

 - the =E2=80=98git blame=E2=80=99 advantage is much bigger than we =
expected; this is probably true for any large project that has many =
contributors to the same file. It doesn=E2=80=99t help much if each file =
basically has an =E2=80=98owner=E2=80=99.
 - people new to PHP liked not having to remember where they are allowed =
and when they=E2=80=99re not. This felt like removing one small =
inconsistency without much of a downside

> On Jun 28, 2015, at 7:19 AM, Jakub Kub=C3=AD=C4=8Dek =
<kelerest123@gmail.com> wrote:
>=20
> +1 for allowing trailing comma in every function call.
>=20
>=20
> Regards,
> Kubo2
>=20
>=20
> 2015-06-18 19:16 GMT+02:00 Florian Anderiasch <ml@anderiasch.de>:
>> On 18.06.2015 08:25, Yasuo Ohgaki wrote:
>>>> If people still consider it more harm- than useful then please =
don't flame
>>>> me and I'll shut up again :-)
>>>>=20
>>>=20
>>> PHP allows
>>>=20
>>> array(
>>>  1,
>>>  2,
>>>  3,
>>> );
>>>=20
>>> therefore
>>>=20
>>> my_variadic_function(
>>>   "foo",
>>>   "bar",
>>>   "qux",
>>> );
>>>=20
>>> is consistent behavior to me.
>>=20
>> If variadic functions allow this and normal functions don't (and by =
most
>> PHP coding standards you'll format like this all the time because of =
80
>> chars limit I don't see how this is in any way consistent. It's still =
a
>> function call after all and not an array.
>>=20
>> ~Florian
>>=20
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>=20
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20


--Apple-Mail=_5CA35980-C30A-4F7C-9848-9B478EB58FE2--