Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86938
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Yasuo Ohgaki'" <yohgaki@ohgaki.net>,
	"'Hannes Magnusson'" <hannes.magnusson@gmail.com>
Cc: "'Kalle Sommer Nielsen'" <kalle@php.net>,
	"'Internals'" <internals@lists.php.net>,
	"'Anatoliy Belsky'" <ab@php.net>,
	"'Dmitry Stogov'" <Dmitry@zend.com>,
	"'Nikita Popov'" <nikita.ppv@gmail.com>,
	"'Ferenc Kovacs'" <tyra3l@gmail.com>,
	"'Xinchen Hui'" <laruence@php.net>
References: <CAJW__o0D_DadKJCyZbMhDiEVpO-pzpWwKV5Ht=ukK1MOBCLCKg@mail.gmail.com> <CAGa2bXaS5Q-qMPtbg855vSVXbSinWv=HA-t26=KB4fQ1tXRUJA@mail.gmail.com> <CADNQb0Vc1vU=ddVD1Dfd4KQ5J7yLhOEVsak6x8mTSo9OUChhZg@mail.gmail.com> <CAGa2bXY3x+gi3VB6X99HFtH_GbBCdsozRdU30BhA52we3a+snQ@mail.gmail.com> <CAGa2bXYzJQpCMYJTM61a_dJ=nJbMRjks5QcnAXocXO3=1Y=s6g@mail.gmail.com> <CAGa2bXYVfcr3pFjkAuzxxx0RR0bUp0Sn9tCjCBVOz3EgAudx8Q@mail.gmail.com>
In-Reply-To: <CAGa2bXYVfcr3pFjkAuzxxx0RR0bUp0Sn9tCjCBVOz3EgAudx8Q@mail.gmail.com>
Date: Mon, 29 Jun 2015 15:19:44 +0200
Message-ID: <02be01d0b26e$469d3940$d3d7abc0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQGUTKtuTUJWqS2AWW/gdyAGZa965wI5Np6tAaTLQpcB25I+zgLA79f6Ae/OqiOd6OzXkA==
Content-Language: en-us
Subject: RE: [PHP-DEV] Headsup: PHP7 feature freeze
From: anatol.php@belski.net ("Anatol Belski")

Hi Yasuo,

> -----Original Message-----
> From: yohgaki@gmail.com [mailto:yohgaki@gmail.com] On Behalf Of Yasuo
> Ohgaki
> Sent: Friday, June 26, 2015 1:58 PM
> To: Hannes Magnusson
> Cc: Kalle Sommer Nielsen; Internals; Anatoliy Belsky; Dmitry Stogov; =
Nikita
> Popov; Ferenc Kovacs; Xinchen Hui
> Subject: Re: [PHP-DEV] Headsup: PHP7 feature freeze
>=20
> Hi all,
>=20
> On Fri, Jun 26, 2015 at 12:56 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> =
wrote:
>=20
> > Hi Hannes,
> >
> > On Fri, Jun 26, 2015 at 12:51 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> =
wrote:
> >
> >> On Fri, Jun 26, 2015 at 10:48 AM, Hannes Magnusson <
> >> hannes.magnusson@gmail.com> wrote:
> >>
> >>> Why do you think its undocumented?
> >>> http://php.net/manual/en/sessionhandler.create-sid.php
> >>>
> >>
> >> Rename discussion was there. And I explicitly discussed "it's
> >> undocumented and it violates CODING_STANDARDS", but it was added
> >> recently (after the discussion I suppose).
> >>
> >> [yohgaki@dev session]$ svn log -r 334814
> >> =
---------------------------------------------------------------------
> >> ---
> >> r334814 | aharvey | 2014-09-09 04:49:26 +0900 =
(2014=E5=B9=B409=E6=9C=8809=E6=97=A5 (=E7=81=AB)) | 2
> >> lines
> >>
> >> Add documentation for SessionHandler::create_sid().
> >>
> >> =
---------------------------------------------------------------------
> >> ---
> >>
> >> 334814    aharvey     <classname>SessionHandler</classname> is a =
special
> >> class that can be used
> >> 334814    aharvey     to expose the current internal PHP session =
save
> >> handler by inheritance.
> >> 334814    aharvey     There are seven methods which wrap the seven
> >> internal session save handler
> >> 334814    aharvey     callbacks (<parameter>open</parameter>,
> >> <parameter>close</parameter>,
> >> 334814    aharvey     <parameter>read</parameter>,
> >> <parameter>write</parameter>,
> >> 334814    aharvey     <parameter>destroy</parameter>,
> >> <parameter>gc</parameter> and
> >> 334814    aharvey     <parameter>create_sid</parameter>).  By =
default,
> >> this class will wrap
> >> 334814    aharvey     whatever internal save handler is set as =
defined by
> >> the
> >> 334814    aharvey     <link
> >> linkend=3D"ini.session.save-handler">session.save_handler</link>
> >> 334814    aharvey     configuration directive which is usually
> >> <parameter>files</parameter> by
> >> 334814    aharvey     default.  Other internal session save =
handlers are
> >> provided by PHP
> >> 334814    aharvey     extensions such as SQLite (as
> >> <parameter>sqlite</parameter>), Memcache (as
> >> 334814    aharvey     <parameter>memcache</parameter>), and =
Memcached
> (as
> >> 334814    aharvey     <parameter>memcached</parameter>).
> >>
> >> I think this should be reverted.
> >>
> >
> > Or it may stay there.
> > It's just a matter of having a copy of create_sid().
> > I'll add documentation.
> >
>=20
> I forgot that session_create_id() is needed createSid() method to be =
more
> useful.
>=20
> The code for session_create_id() is in the source, but it isn't =
enabled.
> I wouldn't like to have different naming session_create_id() and =
createSid().
>=20
> So I would like to have
>  - session_create_id() function
>  - createId() function
> because there is
>  - session_id()
> since PHP4.
>=20
> I don't think session internal names do not have to be changed.
> i.e. Macros, etc.
> Any comments?
>=20
Changing internal or user space API is kind of too late, IMHO. =
Especially the user space APIs that are documented.  But also the =
internals, as a lot of extensions are already ported. Also because =
sessions are a core functionality where changes should be supported but =
a good migration path. Please target later 7.x versions with this =
change. But probably would make sense to create an RFC and start the =
discussion like already... yesterday, so the topic is good discussed and =
accepted for the next.=20

Regards

Anatol