Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86918
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 216.33.127.80 cause and error)
Message-ID: <3DC031A7488D4B869834A0D7E503B751@pc1>
To: "Levi Morrison" <levim@php.net>,
	"Ferenc Kovacs" <tyra3l@gmail.com>
Cc: <internals@lists.php.net>,
	"Yasuo Ohgaki" <yohgaki@ohgaki.net>
References: <CAGa2bXY1hKW3qX3jBwKge7RDihS6TjxAW3p+-kKRiW4OmePLSQ@mail.gmail.com><CAH-PCH6YtrM8B1DBWXL7+5mfgUROKKwqFd2VDL+FZtUEfRpREw@mail.gmail.com> <CAFMT4NrKvi_+cunAqyU=M5FWfjg9VmUXQAVwHfWG9+j_Egm5CQ@mail.gmail.com>
Date: Fri, 26 Jun 2015 16:45:30 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="Windows-1252";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Move to Fast ZPP?
From: php_lists@realplain.com ("Matt Wilmas")

Hi Levi,

----- Original Message -----
From: "Levi Morrison"
Sent: Wednesday, June 24, 2015

> On Wed, Jun 24, 2015 at 3:21 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>> On Wed, Jun 24, 2015 at 3:42 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>>
>>> Hi all,
>>>
>>> I'm wondering the state of Fast ZPP.
>>> https://wiki.php.net/rfc/fast_zpp
>>>
>>> Last year's Dmirty's commit message say, it should
>>> only applied to most used functions due to the state of
>>> Fast ZPP.
>>>
>>> commit 27f38798a1963de1c60aae4ef8a3675138255574
>>> Author: Dmitry Stogov <dmitry@zend.com>
>>> Date:   Fri Jul 11 16:32:20 2014 +0400
>>>
>>>     Fast parameter parsing API
>>>
>>>     This API is experimental. It may be changed or removed.
>>>     It should be used only for really often used functions.
>>>     (Keep the original parsing code and wrap usage with #ifndef 
>>> FAST_ZPP)
>>>
>>>
>>> Are we supposed to convert anything to Fast ZPP now?
>>> What about the  #ifndef FAST_ZPP? Is this required now?
>>>
>>> BTW, if we are supposed to use only Fast ZPP,
>>> https://github.com/php/php-src/blob/master/README.PARAMETER_PARSING_API
>>> should be updated.
>>>
>>> Regards,
>>>
>>> --
>>> Yasuo Ohgaki
>>> yohgaki@ohgaki.net
>>>
>>
>> it was meant as a performance optimization for the most heavy/hot 
>> codepaths.
>> What gave you the idea that the situation changed and we should use it
>> everywhere?
>
> Honestly it has a nicer API and I prefer to use it over traditional
> ZPP in every case.

I think I agree, but thought it was a moot point. :-/

But now I've created a version that uses the same syntax and improves 
performance, but without the code size drawback of the "inlined FAST_ZPP."

So perhaps we WILL be able to use it in every case, depending what 
Dmitry/others think when I share it shortly. :^)


- Matt