Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86865
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1435240516.15676.7.camel@kuechenschabe>
References: <CAF+90c9jJVVOwXGrCYo4yWx=LtfqycccNNS3e8AvAO7PhLkiyA@mail.gmail.com>
	<1435240516.15676.7.camel@kuechenschabe>
Date: Thu, 25 Jun 2015 17:32:20 +0300
Message-ID: <CA+9eiLsi7Pr6N8D4mu82m+NErqf5ESGGP7xhsGoRyB1DTTyB1Q@mail.gmail.com>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec51d2350b361650519587d05
Subject: Re: [PHP-DEV] Allow exceptions in __toString()
From: dmitry@zend.com (Dmitry Stogov)

--bcaec51d2350b361650519587d05
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 25, 2015 at 4:55 PM, Johannes Schl=C3=BCter <johannes@schlueter=
s.de>
wrote:

> On Thu, 2015-06-25 at 14:52 +0200, Nikita Popov wrote:
> > However what it doesn't do, and what I wouldn't consider feasible to do=
,
> is
> > ensure that every single string conversion in library functions is
> > exception safe. Personally I don't think this is a blocking issue, as t=
he
> > worst that can happen is usually an additional superfluous warning to b=
e
> > thrown, or something similar. If cases like this turn up, we can
> > specifically target them.
>
> I don't agree to the assesment that this isn'T a problem. Consider this
> extension pseudo-code:
>
>
>    zval *data =3D get_data();
>    convert_to_string(data);
>    store_into_database(Z_STRVAL_P(data));
>    return TRUE;
>
> This will store wrong data in the database and report to the user that
> there was an error before storing, so the user assumes nothing was
> stored.
>

We have hundreds such cases :(


> The only way we can do that imo is by bailing out if an exception is
> thrown and introducing yet another set of string conversion functions
> for marking exception safe uses. (i.e. convert_to_string_throwing())
>


This may lead to memory and resource leaks.

In general, we may throw exceptions, only from "safe" places, but this
going to make a mesh.

Thanks. Dmitry.



>
> johannes
>
>
>
>

--bcaec51d2350b361650519587d05--