Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86858
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZpheGFt9oBi4irwdZrYQZDwTGPS1X4qzpu1mwvzAsgVg@mail.gmail.com>
References: <CAGa2bXY1hKW3qX3jBwKge7RDihS6TjxAW3p+-kKRiW4OmePLSQ@mail.gmail.com>
	<CAH-PCH6YtrM8B1DBWXL7+5mfgUROKKwqFd2VDL+FZtUEfRpREw@mail.gmail.com>
	<CA+9eiLsrG5TiFEv=2NQPTQxcvMZD9gd0bQLsn7xMQU7HU-oaYQ@mail.gmail.com>
	<CAGa2bXZpheGFt9oBi4irwdZrYQZDwTGPS1X4qzpu1mwvzAsgVg@mail.gmail.com>
Date: Thu, 25 Jun 2015 09:30:57 +0300
Message-ID: <CA+9eiLsfRoxfZLBw1EA3tDaeH7Gqgzv2yNEyh2OxQt78kEfSGw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113ff67c27ee3e051951c40b
Subject: Re: [PHP-DEV] Move to Fast ZPP?
From: dmitry@zend.com (Dmitry Stogov)

--001a113ff67c27ee3e051951c40b
Content-Type: text/plain; charset=UTF-8

On Wed, Jun 24, 2015 at 1:08 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Dmitry,
>
> On Wed, Jun 24, 2015 at 7:04 PM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> We should NOT use it everywhere. It'll lead to code bloat.
>
>
> OK. Thank you.
> I'll use it only for functions called many times. e.g. pg_fetch_*().
> Should I use #ifndef FAST_ZPP?
>
>
I think, ZPP overhead of pg_fetch() is insignificant in comparison to DB
access.
I didn't change API for ext/mysql* only for really often used functions.

Before optimizing something, you'll need to check if you really have a
bottleneck.
Run some application with callgrind, then check how many times ZPP called
from zip_pg_fetch() and its relative cost.
If it less than 0.05%, it makes no sense to do anything.

Over-optimization may make more harm than benefits.

Thanks. Dmitry.



> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>

--001a113ff67c27ee3e051951c40b--