Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:86844 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70722 invoked from network); 24 Jun 2015 10:37:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jun 2015 10:37:34 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.53 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.213.53 mail-yh0-f53.google.com Received: from [209.85.213.53] ([209.85.213.53:35833] helo=mail-yh0-f53.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DE/B2-55790-D688A855 for ; Wed, 24 Jun 2015 06:37:34 -0400 Received: by yhak3 with SMTP id k3so14770526yha.2 for ; Wed, 24 Jun 2015 03:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=1St1iu2kGKl+CQVVvctH4kPtsIc6oZJJgkq8mtsbGi8=; b=zxCf0jBwj6/OaN0sz+21c1nw2nIEWaYY9w+2V/W+Ek8GYyrwGKl7vg4mdJ202HfUSr +AamaiSv1b3PO+asM4RkWtfLqCvk8QXf1gQJVt7kUB/EhWgq63aA5Tb8dRl07Cc85Tpr cRwX5/ux6haMzDXckuAb1laAf/OWJU8eE4JjKwV2KePMGU6ptL3lbRgX+02eOwvy3Pv5 axhCWgvCHHM4VvfXr65NxE3gVcs++y+czlmCd0bZ+OqndcIkoRXOaQL8Qvvrt7kvo27v qA1XI1CpnxwAnL2S3zpN4P4d6g847Mc1Befw6OVfJ1fUIs8F34hBfddnJWmlUK0hhJx9 P14Q== X-Received: by 10.129.98.87 with SMTP id w84mr11270152ywb.32.1435142250375; Wed, 24 Jun 2015 03:37:30 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.129.48.129 with HTTP; Wed, 24 Jun 2015 03:36:51 -0700 (PDT) In-Reply-To: References: Date: Wed, 24 Jun 2015 19:36:51 +0900 X-Google-Sender-Auth: F8DbpXLkT_NXdof6Eb6aP1JyCzg Message-ID: To: Ferenc Kovacs Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a11471004092f420519411832 Subject: Re: [PHP-DEV] Move to Fast ZPP? From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a11471004092f420519411832 Content-Type: text/plain; charset=UTF-8 Hi Ferenc, On Wed, Jun 24, 2015 at 7:29 PM, Ferenc Kovacs wrote: > > > On Wed, Jun 24, 2015 at 12:21 PM, Yasuo Ohgaki wrote: > >> Hi Ferenc, >> >> On Wed, Jun 24, 2015 at 6:21 PM, Ferenc Kovacs wrote: >> >>> it was meant as a performance optimization for the most heavy/hot >>> codepaths. >>> What gave you the idea that the situation changed and we should use it >>> everywhere? >>> >> >> I'm curious about the status of Fast ZPP and it's usage. >> The RFC says it reduces function call overheads by 90% and >> I didn't see reason why we shouldn't move to Fast ZPP. >> >> "For some really simple function like is_string() or ord() the overhead >> of zend_parse_parameters() may be about 90%." >> https://wiki.php.net/rfc/fast_zpp >> >> I'll use it for functions called many times. >> >> > I wouldn't consider the likes of pg_fetch_* to be appropriate for for > using Fast ZPP, even db heavy applications are unlikely to call it more > than a houndred times per request, so the perf gain would be negligible > compared to the increased cost of maintenance. > I agree. It's painful to maintain #ifndef FAST_ZPP zend_parse_parameter(); #else Fast ZPP #endif I'll just leave them alone until #ifndef is not required. Thanks. -- Yasuo Ohgaki yohgaki@ohgaki.net --001a11471004092f420519411832--