Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86843
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 216.33.127.81 cause and error)
Message-ID: <051CB45EE4B24C7C88C3EABC7E8EE0A2@pc1>
To: "Dmitry Stogov" <dmitry@zend.com>,
	"Ferenc Kovacs" <tyra3l@gmail.com>
Cc: "Yasuo Ohgaki" <yohgaki@ohgaki.net>,
	<internals@lists.php.net>
References: <CAGa2bXY1hKW3qX3jBwKge7RDihS6TjxAW3p+-kKRiW4OmePLSQ@mail.gmail.com><CAH-PCH6YtrM8B1DBWXL7+5mfgUROKKwqFd2VDL+FZtUEfRpREw@mail.gmail.com> <CA+9eiLsrG5TiFEv=2NQPTQxcvMZD9gd0bQLsn7xMQU7HU-oaYQ@mail.gmail.com>
Date: Wed, 24 Jun 2015 05:35:30 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="Windows-1252";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Move to Fast ZPP?
From: php_lists@realplain.com ("Matt Wilmas")

Hi Dmitry, all,

----- Original Message -----
From: "Dmitry Stogov"
Sent: Wednesday, June 24, 2015

We should NOT use it everywhere. It'll lead to code bloat.

Thanks. Dmitry.

On Wed, Jun 24, 2015 at 12:21 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:

> On Wed, Jun 24, 2015 at 3:42 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
> > Hi all,
> >
> > I'm wondering the state of Fast ZPP.
> > https://wiki.php.net/rfc/fast_zpp
> >
> > Last year's Dmirty's commit message say, it should
> > only applied to most used functions due to the state of
> > Fast ZPP.
> >
> > commit 27f38798a1963de1c60aae4ef8a3675138255574
> > Author: Dmitry Stogov <dmitry@zend.com>
> > Date:   Fri Jul 11 16:32:20 2014 +0400
> >
> >     Fast parameter parsing API
> >
> >     This API is experimental. It may be changed or removed.
> >     It should be used only for really often used functions.
> >     (Keep the original parsing code and wrap usage with #ifndef 
> > FAST_ZPP)
> >
> >
> > Are we supposed to convert anything to Fast ZPP now?
> > What about the  #ifndef FAST_ZPP? Is this required now?
> >
> > BTW, if we are supposed to use only Fast ZPP,
> > https://github.com/php/php-src/blob/master/README.PARAMETER_PARSING_API
> > should be updated.
> >
> > Regards,
> >
> > --
> > Yasuo Ohgaki
> > yohgaki@ohgaki.net
> >
>
> it was meant as a performance optimization for the most heavy/hot
> codepaths.
> What gave you the idea that the situation changed and we should use it
> everywhere?

Right, FAST_ZPP makes code larger, inlining stuff in each function, etc.

But I was wondering, is there any more that can be done to optimize the 
slowness of the traditional ZPP?  I don't recall any changes being made to 
it in the last 12-18 months to speed it up at all...

Is there a particular part that's making it slow?  Is it the *string* of 
param types?  Is it the va_arg's, that doesn't allow the call to be 
optimized as well and/or the arg fetching that's slow?

I know there were the syntax issues as well, but would using something like 
a single param (array pointer) for param types/values help at all?

Or is it just the internals of ZPP that are inherently slow...? :-/  Or 
that's fine but the "mechanism" of getting there is the issue?


Thanks,
Matt