Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86829
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.216.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXa4EZiVtSR=FOuVNR=VVPfrVO4Ri-A=b82AJ-Hc94cv5Q@mail.gmail.com>
References: <CAGa2bXa9x_BK9O78N_yvAVj7M5V0UEGsy3ch-VOimaqGaKUA3w@mail.gmail.com>
 <CABBJUpeaVXXJ-JJDP+oHUamuDGwM87Myvm4_0qXAh2cZn8rg3A@mail.gmail.com>
 <CAGa2bXYhCNJ_uNQCRbNRhFhfz7rViJ_THUMpA+rddm0fy7gAxQ@mail.gmail.com>
 <CABBJUpdJgHyEhCANQjiB=VrNA8=LFa_sCLr87aid33cH5GTNzw@mail.gmail.com> <CAGa2bXa4EZiVtSR=FOuVNR=VVPfrVO4Ri-A=b82AJ-Hc94cv5Q@mail.gmail.com>
Date: Wed, 24 Jun 2015 10:42:22 +0800
Message-ID: <CABBJUpdq8f95UHAgb7X+8VkrJjqRaBiXoxAxdKednjsCsO7oGA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Optimizing php_html_entities()
From: laruence@php.net (Xinchen Hui)

Hey:

On Wed, Jun 24, 2015 at 10:35 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi Xinchen,
>
> On Wed, Jun 24, 2015 at 11:31 AM, Xinchen Hui <laruence@php.net> wrote:
>>
>>
>>
>>
>> On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>> > Hi Xinchen,
>> >
>> > On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui <laruence@php.net> wrote:
>> >>
>> >> But passing an non-string to htmlspecialchars are not common used
>> >> cases..
>> >>
>> >> "optimize" not common used cases... will bring nothing to us..
>> >
>> >
>> > The reason why I looked into this in the first place is one of my friend
>> > complained about slow htmlspecialchars for relatively large table data.
>> >
>> > He said more than half of execution time is took by htmlspecialchars
>> > because
>> >
>> >  - it escapes numeric values as string
>> >  - it does not accept array value for to be escaped values
>> >
>> > 1st is covered by this patch.
>> > 2nd issue is covered by this FR.
>> >   https://bugs.php.net/bug.php?id=69908
>> >
>> > So it brings something for us :)
>> Then what about strlen(number)?  are you also going to change its ZPP
>> to accept zval instead of string?
>
>
> No. Only some kind of conversion functions are the subject.
> e.g. mb_convert_encoding(), mb_convert_kana(), etc.
What I meant is that it's rarely usage(like strlen(number)). we should
not care about them too much and break arg info.

and for the "age" usage you replied in github, I think the author of
such codes should be aware, if it's only number, then  instead of
htmlespcicalchars($age),  he should use echo $age directly... which is
more faster.

so, I am -1 or this "optimization".

thanks
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/