Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86827
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.216.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYhCNJ_uNQCRbNRhFhfz7rViJ_THUMpA+rddm0fy7gAxQ@mail.gmail.com>
References: <CAGa2bXa9x_BK9O78N_yvAVj7M5V0UEGsy3ch-VOimaqGaKUA3w@mail.gmail.com>
 <CABBJUpeaVXXJ-JJDP+oHUamuDGwM87Myvm4_0qXAh2cZn8rg3A@mail.gmail.com> <CAGa2bXYhCNJ_uNQCRbNRhFhfz7rViJ_THUMpA+rddm0fy7gAxQ@mail.gmail.com>
Date: Wed, 24 Jun 2015 10:31:19 +0800
Message-ID: <CABBJUpdJgHyEhCANQjiB=VrNA8=LFa_sCLr87aid33cH5GTNzw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Optimizing php_html_entities()
From: laruence@php.net (Xinchen Hui)

Hey:



On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi Xinchen,
>
> On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui <laruence@php.net> wrote:
>>
>> But passing an non-string to htmlspecialchars are not common used cases..
>>
>> "optimize" not common used cases... will bring nothing to us..
>
>
> The reason why I looked into this in the first place is one of my friend
> complained about slow htmlspecialchars for relatively large table data.
>
> He said more than half of execution time is took by htmlspecialchars
> because
>
>  - it escapes numeric values as string
>  - it does not accept array value for to be escaped values
>
> 1st is covered by this patch.
> 2nd issue is covered by this FR.
>   https://bugs.php.net/bug.php?id=69908
>
> So it brings something for us :)
Then what about strlen(number)?  are you also going to change its ZPP
to accept zval instead of string?

thanks
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/