Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86823
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 98686 invoked from network); 24 Jun 2015 00:33:21 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 24 Jun 2015 00:33:21 -0000
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.175 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.160.175 mail-yk0-f175.google.com  
Received: from [209.85.160.175] ([209.85.160.175:34126] helo=mail-yk0-f175.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 85/20-31425-ECAF9855 for <internals@lists.php.net>; Tue, 23 Jun 2015 20:33:18 -0400
Received: by ykfy125 with SMTP id y125so15459188ykf.1
        for <internals@lists.php.net>; Tue, 23 Jun 2015 17:33:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=psH5CZ7+cgCyy5haJAui1hd8Nf/HwaZMiQ2Wk4Ipci0=;
        b=j8BwN/UMR+mUyxeH6j0UsqWlbnf2ZbfiBn8GfqGsAhq9CTZqMdmqbKPm8ebWZsBBDi
         ywh+0IXE46BUf0EVF9di+FeNpEEBNkpMFxtHiHonFT5mc86ZzShQiOLm5Sc6GQYsnKBk
         90PyZ35ylTrZrMWc0I1ZvHtuUzQfnLgqDwpsSb3ePEyEFazpBHmtvcNAuUtoaLoF+qwR
         v6eS2RgO+EyS+w3NRDj88DgzfzSBnJEGUIi03IbgNKxe3lu8tJfdQIse6xLBOhxJ9/tY
         gV7WVp3ZwnAll/mOu4ZNwKpcW1jDunzoMfDBuejqI6ENVw3CAxzEFWgi9KiScvXRg1Bb
         nSew==
X-Received: by 10.170.118.80 with SMTP id k77mr17444380ykb.64.1435105995637;
 Tue, 23 Jun 2015 17:33:15 -0700 (PDT)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.129.48.129 with HTTP; Tue, 23 Jun 2015 17:32:36 -0700 (PDT)
In-Reply-To: <CABBJUpeaVXXJ-JJDP+oHUamuDGwM87Myvm4_0qXAh2cZn8rg3A@mail.gmail.com>
References: <CAGa2bXa9x_BK9O78N_yvAVj7M5V0UEGsy3ch-VOimaqGaKUA3w@mail.gmail.com>
 <CABBJUpeaVXXJ-JJDP+oHUamuDGwM87Myvm4_0qXAh2cZn8rg3A@mail.gmail.com>
Date: Wed, 24 Jun 2015 09:32:36 +0900
X-Google-Sender-Auth: 08q8W2zmWfm_2FevFoTNjKAV9dI
Message-ID: <CAGa2bXYhCNJ_uNQCRbNRhFhfz7rViJ_THUMpA+rddm0fy7gAxQ@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1138ea3c15dd4a051938a71c
Subject: Re: [PHP-DEV] Optimizing php_html_entities()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a1138ea3c15dd4a051938a71c
Content-Type: text/plain; charset=UTF-8

Hi Xinchen,

On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui <laruence@php.net> wrote:

> But passing an non-string to htmlspecialchars are not common used cases..
>
> "optimize" not common used cases... will bring nothing to us..
>

The reason why I looked into this in the first place is one of my friend
complained about slow htmlspecialchars for relatively large table data.

He said more than half of execution time is took by htmlspecialchars
because

 - it escapes numeric values as string
 - it does not accept array value for to be escaped values

1st is covered by this patch.
2nd issue is covered by this FR.
  https://bugs.php.net/bug.php?id=69908

So it brings something for us :)

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a1138ea3c15dd4a051938a71c--