Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86817
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 80100 invoked from network); 23 Jun 2015 21:42:25 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 23 Jun 2015 21:42:25 -0000
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.179 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.160.179 mail-yk0-f179.google.com  
Received: from [209.85.160.179] ([209.85.160.179:33517] helo=mail-yk0-f179.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id FC/81-04861-0C2D9855 for <internals@lists.php.net>; Tue, 23 Jun 2015 17:42:24 -0400
Received: by ykdt186 with SMTP id t186so13485090ykd.0
        for <internals@lists.php.net>; Tue, 23 Jun 2015 14:42:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=KG/ofK90qohJqNGkRebiy8P1JH1rUQi/NAhPIPb7rsY=;
        b=s4Fh7VW1E8zoVfr1PBacxhWa3wYNFHYf0zg59h6HOdyOpYnym89khOT7IquXuHv30w
         4dCzRTlRHTtGv7Fcengz6pWMUySa4eTDT8Zwv7tl7fXYOhKGb9x2kdIcTJkT3J4Yvd2f
         7z9n7cvUrrSqT9irC/4sAURTUUkY8BIbrzX8Ixjmb36IPkfpvi3RO3zCbCWRtyxLzHdn
         6WOKruFnXsXNTH3q4q8rn8ErVUV4A29D85VewxFuNbKKtD4yZNZjZjPzXh8hDOsJPaD1
         8jDTpmXFWTTXgBgADlhRmO6Vq0CfuxRuz58CfT81br7Lxumv2pBdlaw5cEriinOcNvgN
         8vJg==
X-Received: by 10.13.226.75 with SMTP id l72mr46599934ywe.89.1435095741881;
 Tue, 23 Jun 2015 14:42:21 -0700 (PDT)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.129.48.129 with HTTP; Tue, 23 Jun 2015 14:41:42 -0700 (PDT)
In-Reply-To: <CAAyV7nHo2jWSNYL-BQc-yg2SoTzOpNFvcmLNpH9vhL9w3_ab7w@mail.gmail.com>
References: <CAGa2bXa9x_BK9O78N_yvAVj7M5V0UEGsy3ch-VOimaqGaKUA3w@mail.gmail.com>
 <CABBJUpeaVXXJ-JJDP+oHUamuDGwM87Myvm4_0qXAh2cZn8rg3A@mail.gmail.com> <CAAyV7nHo2jWSNYL-BQc-yg2SoTzOpNFvcmLNpH9vhL9w3_ab7w@mail.gmail.com>
Date: Wed, 24 Jun 2015 06:41:42 +0900
X-Google-Sender-Auth: mKu-wwsB2I73p8k5SzCCWWnQXbg
Message-ID: <CAGa2bXYRB1Mo6B9WA0knrJ6ziKukaNY18aiYzj-QfvYA+o0VVQ@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: Xinchen Hui <laruence@php.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114fae22e9e4ba05193643a5
Subject: Re: [PHP-DEV] Optimizing php_html_entities()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a114fae22e9e4ba05193643a5
Content-Type: text/plain; charset=UTF-8

Hi Anthony,

On Wed, Jun 24, 2015 at 12:21 AM, Anthony Ferrara <ircmaxell@gmail.com>
wrote:

> In addition, this breaks the contract, specifically when using scalar
> types. Because you're no longer going to error when the contract is
> broken (considering htmlspecialchars is documented as string:string).
>

What do you mean by "break the contract".
"string" parameter is not a requirement/contract.
htmlspecialchars/htmlentities
just converts param to string. The patch does not change anything as you
can
see it from the phpt results.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a114fae22e9e4ba05193643a5--