Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86808
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.175 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Date: Tue, 23 Jun 2015 20:37:04 +0900
Message-ID: <CAGa2bXa9x_BK9O78N_yvAVj7M5V0UEGsy3ch-VOimaqGaKUA3w@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113980408fadaa05192dd179
Subject: Optimizing php_html_entities()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a113980408fadaa05192dd179
Content-Type: text/plain; charset=UTF-8

Hi all,

I'm trying to optimize php_html_entities().
Since htmlspecialchars()/htmlentities() are sensitive function, I would
like to ask comments before merge.

https://github.com/php/php-src/pull/1356

Current php_html_entities() convert int/float/etc to string, then convert
it.
int/float/etc is not required to be escaped. Optimize it by simply
converting them to string.

Simple benchmark shows about 60% execution time reduction.

[yohgaki@dev github-php-src]$ ./php-bin b.php
Time: 10.484607934952
[yohgaki@dev github-php-src]$ ./php-bin b.php
Time: 10.867615222931
[yohgaki@dev github-php-src]$ ./php.new b.php
Time: 3.9379420280457
[yohgaki@dev github-php-src]$ ./php.new b.php
Time: 4.0694711208344
[yohgaki@dev github-php-src]$ cat b.php
<?php
const LOOP=100000000;

$start = microtime(true);
for ($i = 0; $i < LOOP; $i++) {
}
$loop_time = microtime(true) - $start;

$start = microtime(true);
for ($i = 0; $i < LOOP; $i++) {
htmlspecialchars(123456790);
}
echo 'Time: '.(microtime(true) - $start - $loop_time)."\n";


--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a113980408fadaa05192dd179--