Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86802
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.49 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <5588AEFC.1030409@lerdorf.com>
References: <5586E5D1.4010901@lerdorf.com>
	<CAF+90c9Nxr70100SeBKgaTGGyD6MDQjWYSvjn6ZdkaJbrCZqLA@mail.gmail.com>
	<55870947.4060304@lerdorf.com>
	<CAJW__o1fGEszJ7c3oP7wz0=TGWwmwKKYS823=7yz12Pm6Uej4A@mail.gmail.com>
	<5587334C.2080401@lerdorf.com>
	<CAF+90c_gkv=u5+4kf1aHJ_KE+ULP20Y-0hgGU2Zu+vXvhjp-qg@mail.gmail.com>
	<55873676.6050706@gmail.com>
	<55876B29.90804@lerdorf.com>
	<CA+9eiLvupv0fV=mfFz0bLVXzE1mkTN4BN40SE96T6NaAZ+Vasg@mail.gmail.com>
	<55881A72.4090403@lerdorf.com>
	<CA+9eiLt=HD2EqVnX+o8Sm+vuUpqCOBBN=S_BDwWJDttuamc14w@mail.gmail.com>
	<5588477E.7050109@lerdorf.com>
	<CA+9eiLt6ZZx=D9cEX64KGjb-0aAuiDn6f5eQ94qJQxRoRPBkkQ@mail.gmail.com>
	<5588A02C.4040602@gmail.com>
	<5588AEFC.1030409@lerdorf.com>
Date: Mon, 22 Jun 2015 21:09:16 -0600
Message-ID: <CAFMT4NqPpp39h7m1HCYsVJpSoqgZTyKKSknzVNxBc2h9YHNptQ@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, Dmitry Stogov <dmitry@zend.com>, 
	Bob Weinand <bobwei9@hotmail.com>, Anatol Belski <anatol.php@belski.net>, 
	Kalle Sommer Nielsen <kalle@php.net>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] hasType() for internal function parameters?
From: levim@php.net (Levi Morrison)

On Mon, Jun 22, 2015 at 6:57 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
> On 06/22/2015 07:54 PM, Stanislav Malyshev wrote:
>> Hi!
>>
>> So I tried to remove the checks for ZEND_ACC_HAS_TYPE_HINTS:
>> https://github.com/php/php-src/pull/1354
>>
>> Turns out there is a lot of tests that assume function with wrong
>> arguments throws Error, but ZPP and type checks work differently - ZPP
>> first checks argument number (and doesn't throw if number is wrong but
>> instead creates warning), while type checks (that shouldn't really
>> happen on internals but do) check types first and not check argument number.
>>
>> So I wonder which way is the best to proceed here. Looks like this comes
>> from 5.6 where internal function types were verified in executor:
>> https://github.com/php/php-src/blob/PHP-5.6/Zend/zend_vm_def.h#L1974
>>
>> I'm not sure what to do with it - on one side, I think ZPP should handle
>> it for internal functions, otherwise we're doing the same work twice. On
>> the other side, that would be pretty substantial, even if maybe correct,
>> BC break. Should we keep the ZEND_ACC_HAS_TYPE_HINTS type checks and
>> accept the fact that this way we're checking everything twice, or should
>> be clean it up?
>
> Is it a BC break against real code though? Fixing tests isn't a big
> deal. What kind of real code would break by turning calls with the wrong
> number of args from an error to a warning?
>
> I suppose it is a bit late in the game to fix this, but it really does
> seem very broken to the point where I wonder if we shouldn't just
> disable reflection on internal functions entirely since the arginfo is
> so woefully incomplete. Plus the double-checking is super messy.

One thing I really want to work towards in the future is consistency
between user-land and internal functions. There are currently multiple
observable differences. Maybe it would be best to post-pone these
changes until 8.0 where we can do a large consistency pass and handle
it then.