Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86801
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.192.49 as permitted sender)
Message-ID: <5588AEFC.1030409@lerdorf.com>
Date: Mon, 22 Jun 2015 20:57:32 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Stanislav Malyshev <smalyshev@gmail.com>, 
 Dmitry Stogov <dmitry@zend.com>
CC: Bob Weinand <bobwei9@hotmail.com>, 
 Anatol Belski <anatol.php@belski.net>,
 Kalle Sommer Nielsen <kalle@php.net>, 
 Nikita Popov <nikita.ppv@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <5586E5D1.4010901@lerdorf.com>	<CAF+90c9Nxr70100SeBKgaTGGyD6MDQjWYSvjn6ZdkaJbrCZqLA@mail.gmail.com>	<55870947.4060304@lerdorf.com>	<CAJW__o1fGEszJ7c3oP7wz0=TGWwmwKKYS823=7yz12Pm6Uej4A@mail.gmail.com>	<5587334C.2080401@lerdorf.com>	<CAF+90c_gkv=u5+4kf1aHJ_KE+ULP20Y-0hgGU2Zu+vXvhjp-qg@mail.gmail.com>	<55873676.6050706@gmail.com>	<55876B29.90804@lerdorf.com>	<CA+9eiLvupv0fV=mfFz0bLVXzE1mkTN4BN40SE96T6NaAZ+Vasg@mail.gmail.com>	<55881A72.4090403@lerdorf.com>	<CA+9eiLt=HD2EqVnX+o8Sm+vuUpqCOBBN=S_BDwWJDttuamc14w@mail.gmail.com>	<5588477E.7050109@lerdorf.com> <CA+9eiLt6ZZx=D9cEX64KGjb-0aAuiDn6f5eQ94qJQxRoRPBkkQ@mail.gmail.com> <5588A02C.4040602@gmail.com>
In-Reply-To: <5588A02C.4040602@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="I5rohbCJV8920aX0XTR4bpUCpkwl1b72I"
Subject: Re: [PHP-DEV] hasType() for internal function parameters?
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--I5rohbCJV8920aX0XTR4bpUCpkwl1b72I
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/22/2015 07:54 PM, Stanislav Malyshev wrote:
> Hi!
>=20
> So I tried to remove the checks for ZEND_ACC_HAS_TYPE_HINTS:
> https://github.com/php/php-src/pull/1354
>=20
> Turns out there is a lot of tests that assume function with wrong
> arguments throws Error, but ZPP and type checks work differently - ZPP
> first checks argument number (and doesn't throw if number is wrong but
> instead creates warning), while type checks (that shouldn't really
> happen on internals but do) check types first and not check argument nu=
mber.
>=20
> So I wonder which way is the best to proceed here. Looks like this come=
s
> from 5.6 where internal function types were verified in executor:
> https://github.com/php/php-src/blob/PHP-5.6/Zend/zend_vm_def.h#L1974
>=20
> I'm not sure what to do with it - on one side, I think ZPP should handl=
e
> it for internal functions, otherwise we're doing the same work twice. O=
n
> the other side, that would be pretty substantial, even if maybe correct=
,
> BC break. Should we keep the ZEND_ACC_HAS_TYPE_HINTS type checks and
> accept the fact that this way we're checking everything twice, or shoul=
d
> be clean it up?

Is it a BC break against real code though? Fixing tests isn't a big
deal. What kind of real code would break by turning calls with the wrong
number of args from an error to a warning?

I suppose it is a bit late in the game to fix this, but it really does
seem very broken to the point where I wonder if we shouldn't just
disable reflection on internal functions entirely since the arginfo is
so woefully incomplete. Plus the double-checking is super messy.

-Rasmus




--I5rohbCJV8920aX0XTR4bpUCpkwl1b72I
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlWIrvwACgkQlxayKTuqOuDIZACfe70pWpESxD0YEKPYkOwYtc+/
iHQAn1zASmtlc97FYXiFcIbq+n3hf6Ya
=nwz5
-----END PGP SIGNATURE-----

--I5rohbCJV8920aX0XTR4bpUCpkwl1b72I--