Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86790
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.192.41 as permitted sender)
Message-ID: <55885D88.8060902@lerdorf.com>
Date: Mon, 22 Jun 2015 15:10:00 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Dmitry Stogov <dmitry@zend.com>
CC: Bob Weinand <bobwei9@hotmail.com>, 
 Anatol Belski <anatol.php@belski.net>,
 Kalle Sommer Nielsen <kalle@php.net>, 
 Stanislav Malyshev <smalyshev@gmail.com>,
 Nikita Popov <nikita.ppv@gmail.com>, 
 PHP internals <internals@lists.php.net>
References: <5586E5D1.4010901@lerdorf.com>	<CAF+90c9Nxr70100SeBKgaTGGyD6MDQjWYSvjn6ZdkaJbrCZqLA@mail.gmail.com>	<55870947.4060304@lerdorf.com>	<CAJW__o1fGEszJ7c3oP7wz0=TGWwmwKKYS823=7yz12Pm6Uej4A@mail.gmail.com>	<5587334C.2080401@lerdorf.com>	<CAF+90c_gkv=u5+4kf1aHJ_KE+ULP20Y-0hgGU2Zu+vXvhjp-qg@mail.gmail.com>	<55873676.6050706@gmail.com>	<55876B29.90804@lerdorf.com>	<CA+9eiLvupv0fV=mfFz0bLVXzE1mkTN4BN40SE96T6NaAZ+Vasg@mail.gmail.com>	<55881A72.4090403@lerdorf.com>	<CA+9eiLt=HD2EqVnX+o8Sm+vuUpqCOBBN=S_BDwWJDttuamc14w@mail.gmail.com>	<5588477E.7050109@lerdorf.com> <CA+9eiLt6ZZx=D9cEX64KGjb-0aAuiDn6f5eQ94qJQxRoRPBkkQ@mail.gmail.com>
In-Reply-To: <CA+9eiLt6ZZx=D9cEX64KGjb-0aAuiDn6f5eQ94qJQxRoRPBkkQ@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="kGamktHrPO3KLhKtsGDvK1pQSFjejcV2d"
Subject: Re: [PHP-DEV] hasType() for internal function parameters?
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--kGamktHrPO3KLhKtsGDvK1pQSFjejcV2d
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/22/2015 03:00 PM, Dmitry Stogov wrote:
>=20
>=20
> On Mon, Jun 22, 2015 at 8:35 PM, Rasmus Lerdorf <rasmus@lerdorf.com
> <mailto:rasmus@lerdorf.com>> wrote:
>=20
>     On 06/22/2015 01:27 PM, Dmitry Stogov wrote:
>     > Actually, when you added type hints, php compiler stopped optimiz=
ing and
>     > using ZEND_DEFINED (and others) instead of internal function call=
s, but
>     > of course this shouldn't change behavior. I'll need to take a loo=
k into
>     > difference.
>=20
>     Right, behaviour shouldn't change, but couldn't we also make it so =
that
>     arginfo for internal calls is only used by reflection? We can do al=
l the
>     type checking we need right in ZPP as we do now. Let's just ignore
>     arginfo entirely for these calls.
>=20
>=20
> In general, we can, if we remove corresponding code in zend_vm_def.h,
> and also some checks for ZEND_HAS_TYPE_INFO and internal functions in
> zend_compile.c.

I think that is the way to go. We didn't have any type info there before
so we are not losing any functionality, and obviously adding it produces
weird side effects and slows things down. Plus we should get a very
small performance increase by removing the type info check entirely.

-Rasmus


--kGamktHrPO3KLhKtsGDvK1pQSFjejcV2d
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlWIXYgACgkQlxayKTuqOuDrnwCeL8twnSPQlcH4+PVlU0Ydv4Ry
lsMAnjGOqnMqXJwzgQfgTG/854B5vUg1
=Rxh6
-----END PGP SIGNATURE-----

--kGamktHrPO3KLhKtsGDvK1pQSFjejcV2d--