Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86787
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.216.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <55881A72.4090403@lerdorf.com>
References: <5586E5D1.4010901@lerdorf.com>
	<CAF+90c9Nxr70100SeBKgaTGGyD6MDQjWYSvjn6ZdkaJbrCZqLA@mail.gmail.com>
	<55870947.4060304@lerdorf.com>
	<CAJW__o1fGEszJ7c3oP7wz0=TGWwmwKKYS823=7yz12Pm6Uej4A@mail.gmail.com>
	<5587334C.2080401@lerdorf.com>
	<CAF+90c_gkv=u5+4kf1aHJ_KE+ULP20Y-0hgGU2Zu+vXvhjp-qg@mail.gmail.com>
	<55873676.6050706@gmail.com>
	<55876B29.90804@lerdorf.com>
	<CA+9eiLvupv0fV=mfFz0bLVXzE1mkTN4BN40SE96T6NaAZ+Vasg@mail.gmail.com>
	<55881A72.4090403@lerdorf.com>
Date: Mon, 22 Jun 2015 20:27:52 +0300
Message-ID: <CA+9eiLt=HD2EqVnX+o8Sm+vuUpqCOBBN=S_BDwWJDttuamc14w@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Bob Weinand <bobwei9@hotmail.com>, Anatol Belski <anatol.php@belski.net>, 
	Kalle Sommer Nielsen <kalle@php.net>, Stanislav Malyshev <smalyshev@gmail.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf3079c0a4f15b1405191e97d2
Subject: Re: [PHP-DEV] hasType() for internal function parameters?
From: dmitry@zend.com (Dmitry Stogov)

--20cf3079c0a4f15b1405191e97d2
Content-Type: text/plain; charset=UTF-8

On Mon, Jun 22, 2015 at 5:23 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:

> On 06/22/2015 05:11 AM, Dmitry Stogov wrote:
> > Hi Rasmus,
> >
> > Your latest changes broke more than 100 tests.
> > Sorry, but I had to revert your commits and related Bob's fixes.
> > You may find them in internal-arg-info branch.
> >
> > Please, don't do experiments on the common code base at beta stage.
> > On the other hand, I don't see a big problem committing this, when a
> > complete solution is ready.
>
> Oops, way more test failures than I expected. But I don't understand
> some of them. For example, Zend/tests/constants_008.phpt which is:
>
>     <?php
>     define('a', 2);
>     const a = 1;
>     if (defined('a')) {
>         print a;
>     }
>
> With arginfo filled in correctly for define() and defined() the output is:
>
> ../../sapi/cli/php -derror_reporting=-1 constants_008.php
> Notice: Constant a already defined in Zend/tests/constants_008.php on line
> 4
> 1
>
> And without arginfo:
>
> php -derror_reporting=-1 constants_008.php
> Notice: Constant a already defined in Zend/tests/constants_008.php on line
> 4
> 2
>
> I wasn't expecting fixing arginfo would change how constants behave.
>

Actually, when you added type hints, php compiler stopped optimizing and
using ZEND_DEFINED (and others) instead of internal function calls, but of
course this shouldn't change behavior. I'll need to take a look into
difference.

Thanks. Dmitry.


>
> -Rasmus
>
>

--20cf3079c0a4f15b1405191e97d2--