Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86785
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.220.174 as permitted sender)
Message-ID: <55881A72.4090403@lerdorf.com>
Date: Mon, 22 Jun 2015 10:23:46 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Dmitry Stogov <dmitry@zend.com>, Bob Weinand <bobwei9@hotmail.com>, 
 Anatol Belski <anatol.php@belski.net>,
 Kalle Sommer Nielsen <kalle@php.net>
CC: Stanislav Malyshev <smalyshev@gmail.com>, 
 Nikita Popov <nikita.ppv@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <5586E5D1.4010901@lerdorf.com>	<CAF+90c9Nxr70100SeBKgaTGGyD6MDQjWYSvjn6ZdkaJbrCZqLA@mail.gmail.com>	<55870947.4060304@lerdorf.com>	<CAJW__o1fGEszJ7c3oP7wz0=TGWwmwKKYS823=7yz12Pm6Uej4A@mail.gmail.com>	<5587334C.2080401@lerdorf.com>	<CAF+90c_gkv=u5+4kf1aHJ_KE+ULP20Y-0hgGU2Zu+vXvhjp-qg@mail.gmail.com>	<55873676.6050706@gmail.com>	<55876B29.90804@lerdorf.com> <CA+9eiLvupv0fV=mfFz0bLVXzE1mkTN4BN40SE96T6NaAZ+Vasg@mail.gmail.com>
In-Reply-To: <CA+9eiLvupv0fV=mfFz0bLVXzE1mkTN4BN40SE96T6NaAZ+Vasg@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="DdSfxxg814gQUXKiSe4iLCd2vtemHjaFw"
Subject: Re: [PHP-DEV] hasType() for internal function parameters?
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--DdSfxxg814gQUXKiSe4iLCd2vtemHjaFw
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/22/2015 05:11 AM, Dmitry Stogov wrote:
> Hi Rasmus,
>=20
> Your latest changes broke more than 100 tests.
> Sorry, but I had to revert your commits and related Bob's fixes.
> You may find them in internal-arg-info branch.
>=20
> Please, don't do experiments on the common code base at beta stage.
> On the other hand, I don't see a big problem committing this, when a
> complete solution is ready.

Oops, way more test failures than I expected. But I don't understand
some of them. For example, Zend/tests/constants_008.phpt which is:

    <?php
    define('a', 2);
    const a =3D 1;
    if (defined('a')) {
	print a;
    }

With arginfo filled in correctly for define() and defined() the output is=
:

=2E./../sapi/cli/php -derror_reporting=3D-1 constants_008.php
Notice: Constant a already defined in Zend/tests/constants_008.php on lin=
e 4
1

And without arginfo:

php -derror_reporting=3D-1 constants_008.php
Notice: Constant a already defined in Zend/tests/constants_008.php on lin=
e 4
2

I wasn't expecting fixing arginfo would change how constants behave.

-Rasmus


--DdSfxxg814gQUXKiSe4iLCd2vtemHjaFw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlWIGnIACgkQlxayKTuqOuB2LwCdFs7BVjKcUCA8Y323Zp+nf195
AfEAnifpWw+0Z9tOFF4rDLlo4uY5v8/J
=av1K
-----END PGP SIGNATURE-----

--DdSfxxg814gQUXKiSe4iLCd2vtemHjaFw--