Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86780
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.216.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <55876B29.90804@lerdorf.com>
References: <5586E5D1.4010901@lerdorf.com>
	<CAF+90c9Nxr70100SeBKgaTGGyD6MDQjWYSvjn6ZdkaJbrCZqLA@mail.gmail.com>
	<55870947.4060304@lerdorf.com>
	<CAJW__o1fGEszJ7c3oP7wz0=TGWwmwKKYS823=7yz12Pm6Uej4A@mail.gmail.com>
	<5587334C.2080401@lerdorf.com>
	<CAF+90c_gkv=u5+4kf1aHJ_KE+ULP20Y-0hgGU2Zu+vXvhjp-qg@mail.gmail.com>
	<55873676.6050706@gmail.com>
	<55876B29.90804@lerdorf.com>
Date: Mon, 22 Jun 2015 12:11:23 +0300
Message-ID: <CA+9eiLvupv0fV=mfFz0bLVXzE1mkTN4BN40SE96T6NaAZ+Vasg@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>, Bob Weinand <bobwei9@hotmail.com>, 
	Anatol Belski <anatol.php@belski.net>, Kalle Sommer Nielsen <kalle@php.net>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134c6e6696ae0051917a823
Subject: Re: [PHP-DEV] hasType() for internal function parameters?
From: dmitry@zend.com (Dmitry Stogov)

--001a1134c6e6696ae0051917a823
Content-Type: text/plain; charset=UTF-8

Hi Rasmus,

Your latest changes broke more than 100 tests.
Sorry, but I had to revert your commits and related Bob's fixes.
You may find them in internal-arg-info branch.

Please, don't do experiments on the common code base at beta stage.
On the other hand, I don't see a big problem committing this, when a
complete solution is ready.

Thanks. Dmitry.

On Mon, Jun 22, 2015 at 4:55 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:

> On 06/21/2015 06:11 PM, Stanislav Malyshev wrote:
> > Hi!
> >
> >> Before making more extensive use of arginfo types, I think we should
> first
> >> do some adjustments to the way they are handled. In particular adding
> types
> >> means that internal fcalls will take the branch in
> >> http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_vm_def.h#3669. As this is
> hot
> >> code, it is likely important to avoid doing those duplicate type checks
> >> (that will also happen in zpp anyway). As such I would suggest to make
> >> arginfo for internal functions reflection-only. Return type hints are
> >> already only enforced in debug mode.
> >
> > Agreed, for internals arginfo types should be reflection-only. I imagine
> > that would be very easy to fix just by checking for function type?
>
> Ok, I have fixed the arginfo for all the built-in engine functions.
> I wrote a little script which generates it from the doc-comments in the
> code. I think the easiest way to do it is to first go through the file
> and check the "{{{ proto" comments to make sure the optional args are
> denoted correctly and no args are missing.
>
> To run it:
>
> script/dev/genarginfo.php Zend/zend_builtin_functions.c
>
> for example.
>
> -Rasmus
>
>

--001a1134c6e6696ae0051917a823--