Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86777
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.220.177 as permitted sender)
Message-ID: <55876B29.90804@lerdorf.com>
Date: Sun, 21 Jun 2015 21:55:53 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Stanislav Malyshev <smalyshev@gmail.com>, 
 Nikita Popov <nikita.ppv@gmail.com>
CC: Kalle Sommer Nielsen <kalle@php.net>, 
 PHP internals <internals@lists.php.net>
References: <5586E5D1.4010901@lerdorf.com>	<CAF+90c9Nxr70100SeBKgaTGGyD6MDQjWYSvjn6ZdkaJbrCZqLA@mail.gmail.com>	<55870947.4060304@lerdorf.com>	<CAJW__o1fGEszJ7c3oP7wz0=TGWwmwKKYS823=7yz12Pm6Uej4A@mail.gmail.com>	<5587334C.2080401@lerdorf.com> <CAF+90c_gkv=u5+4kf1aHJ_KE+ULP20Y-0hgGU2Zu+vXvhjp-qg@mail.gmail.com> <55873676.6050706@gmail.com>
In-Reply-To: <55873676.6050706@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="GXRcwdAR3hKt7mHHS5hqkT8CNS4alxpnn"
Subject: Re: [PHP-DEV] hasType() for internal function parameters?
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--GXRcwdAR3hKt7mHHS5hqkT8CNS4alxpnn
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/21/2015 06:11 PM, Stanislav Malyshev wrote:
> Hi!
>=20
>> Before making more extensive use of arginfo types, I think we should f=
irst
>> do some adjustments to the way they are handled. In particular adding =
types
>> means that internal fcalls will take the branch in
>> http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_vm_def.h#3669. As this is =
hot
>> code, it is likely important to avoid doing those duplicate type check=
s
>> (that will also happen in zpp anyway). As such I would suggest to make=

>> arginfo for internal functions reflection-only. Return type hints are
>> already only enforced in debug mode.
>=20
> Agreed, for internals arginfo types should be reflection-only. I imagin=
e
> that would be very easy to fix just by checking for function type?

Ok, I have fixed the arginfo for all the built-in engine functions.
I wrote a little script which generates it from the doc-comments in the
code. I think the easiest way to do it is to first go through the file
and check the "{{{ proto" comments to make sure the optional args are
denoted correctly and no args are missing.

To run it:

script/dev/genarginfo.php Zend/zend_builtin_functions.c

for example.

-Rasmus


--GXRcwdAR3hKt7mHHS5hqkT8CNS4alxpnn
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlWHaykACgkQlxayKTuqOuCBtACfU4ztHqoTmJEMsgxqjkAw26qc
cwEAn3SDkfyBg1onLWtpOOXIz6r7HH0v
=dz6e
-----END PGP SIGNATURE-----

--GXRcwdAR3hKt7mHHS5hqkT8CNS4alxpnn--