Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86775
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.44 as permitted sender)
Message-ID: <55873676.6050706@gmail.com>
Date: Sun, 21 Jun 2015 15:11:02 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Nikita Popov <nikita.ppv@gmail.com>, 
 Rasmus Lerdorf <rasmus@lerdorf.com>
CC: Kalle Sommer Nielsen <kalle@php.net>, 
 PHP internals <internals@lists.php.net>
References: <5586E5D1.4010901@lerdorf.com>	<CAF+90c9Nxr70100SeBKgaTGGyD6MDQjWYSvjn6ZdkaJbrCZqLA@mail.gmail.com>	<55870947.4060304@lerdorf.com>	<CAJW__o1fGEszJ7c3oP7wz0=TGWwmwKKYS823=7yz12Pm6Uej4A@mail.gmail.com>	<5587334C.2080401@lerdorf.com> <CAF+90c_gkv=u5+4kf1aHJ_KE+ULP20Y-0hgGU2Zu+vXvhjp-qg@mail.gmail.com>
In-Reply-To: <CAF+90c_gkv=u5+4kf1aHJ_KE+ULP20Y-0hgGU2Zu+vXvhjp-qg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] hasType() for internal function parameters?
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Before making more extensive use of arginfo types, I think we should first
> do some adjustments to the way they are handled. In particular adding types
> means that internal fcalls will take the branch in
> http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_vm_def.h#3669. As this is hot
> code, it is likely important to avoid doing those duplicate type checks
> (that will also happen in zpp anyway). As such I would suggest to make
> arginfo for internal functions reflection-only. Return type hints are
> already only enforced in debug mode.

Agreed, for internals arginfo types should be reflection-only. I imagine
that would be very easy to fix just by checking for function type?

-- 
Stas Malyshev
smalyshev@gmail.com