Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86772
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.220.182 as permitted sender)
Message-ID: <5587334C.2080401@lerdorf.com>
Date: Sun, 21 Jun 2015 17:57:32 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Kalle Sommer Nielsen <kalle@php.net>
CC: Nikita Popov <nikita.ppv@gmail.com>, 
 PHP internals <internals@lists.php.net>
References: <5586E5D1.4010901@lerdorf.com>	<CAF+90c9Nxr70100SeBKgaTGGyD6MDQjWYSvjn6ZdkaJbrCZqLA@mail.gmail.com>	<55870947.4060304@lerdorf.com> <CAJW__o1fGEszJ7c3oP7wz0=TGWwmwKKYS823=7yz12Pm6Uej4A@mail.gmail.com>
In-Reply-To: <CAJW__o1fGEszJ7c3oP7wz0=TGWwmwKKYS823=7yz12Pm6Uej4A@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="Gksn7s07CDdjwhxFCeCTVSbHbkwUErcEo"
Subject: Re: [PHP-DEV] hasType() for internal function parameters?
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--Gksn7s07CDdjwhxFCeCTVSbHbkwUErcEo
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 06/21/2015 03:40 PM, Kalle Sommer Nielsen wrote:
> Hi
>=20
> 2015-06-21 20:58 GMT+02:00 Rasmus Lerdorf <rasmus@lerdorf.com>:
>> Or we bite the bullet and fix the arginfo everywhere to make it
>> consistent. It wouldn't be that hard to write a script to generate the=

>> bulk of it.
>=20
> I think fixing arginfo sounds like the right solution, writing a
> script for it should not be so trival.

Even the ones that have some arginfo aren't all correct.

For example:

https://github.com/php/php-src/blob/master/Zend/zend_builtin_functions.c#=
L132

which currently says:

ZEND_BEGIN_ARG_INFO_EX(arginfo_define, 0, 0, 3)
	ZEND_ARG_INFO(0, constant_name)
	ZEND_ARG_INFO(0, value)
	ZEND_ARG_INFO(0, case_insensitive)
ZEND_END_ARG_INFO()

That says there are 3 required params when it should clearly be 2.

But really that block should be:

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_define, 0, 2, _IS_BOOL,
0, 0)
    ZEND_ARG_TYPE_INFO(0, constant_name, IS_STRING, 0)
    ZEND_ARG_INFO(0, value)
    ZEND_ARG_TYPE_INFO(0, case_insensitive, _IS_BOOL, 0)
ZEND_END_ARG_INFO()

It seems way too lazy to not fix these before we release 7.0. Especially
the ones that are outright wrong. So, having called us lazy, I better
dig in and do something about it. I'll fix up all of the ones in
zend_builtin_functions.c today. And move on to others after. Definitely
a tedious task that we could use some extra hands on.

-Rasmus


--Gksn7s07CDdjwhxFCeCTVSbHbkwUErcEo
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlWHM0wACgkQlxayKTuqOuDbUACdHOHDh35hD9YA8E2hlzTj+t7d
MOgAn3y+q34dYQlzlSTbko+x63lAH6BS
=aIZq
-----END PGP SIGNATURE-----

--Gksn7s07CDdjwhxFCeCTVSbHbkwUErcEo--