Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86768
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5586E5D1.4010901@lerdorf.com>
References: <5586E5D1.4010901@lerdorf.com>
Date: Sun, 21 Jun 2015 20:44:39 +0200
Message-ID: <CAF+90c9Nxr70100SeBKgaTGGyD6MDQjWYSvjn6ZdkaJbrCZqLA@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bf0ef18b1503c05190b8ce4
Subject: Re: [PHP-DEV] hasType() for internal function parameters?
From: nikita.ppv@gmail.com (Nikita Popov)

--047d7bf0ef18b1503c05190b8ce4
Content-Type: text/plain; charset=UTF-8

On Sun, Jun 21, 2015 at 6:26 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:

> Is it deliberate that we are not providing the parameter types for
> internal functions via reflection? It seems inconsistent:
>
>     <?php
>     declare(strict_types=1);
>     function ustrlen(string $str) { }
>     $param_ustrlen = (new
> ReflectionFunction('ustrlen'))->getParameters()[0];
>     $param_strlen = (new ReflectionFunction('strlen'))->getParameters()[0];
>
>     echo "$param_ustrlen (".$param_ustrlen->hasType().")\n";
>     echo "$param_strlen (".$param_strlen->hasType().")\n";
>
>     try {
>         ustrlen(1);
>     } catch (TypeError $e) {
>         echo $e->getMessage()."\n";
>     }
>
>     try {
>         strlen(1);
>     } catch (TypeError $e) {
>         echo $e->getMessage()."\n";
>     }
>
> The output is:
>
> Parameter #0 [ <required> string $str ] (1)
> Parameter #0 [ <required> $str ] ()
> Argument 1 passed to ustrlen() must be of the type string, integer
> given, called in /home/rasmus/prop.php on line 11
> strlen() expects parameter 1 to be string, integer given
>
> That is, in both cases a TypeError exception is raised because the type
> of the parameter is incorrect. But hasType() on the internal function
> parameter claims there is no type even though there obviously is one.
>
> -Rasmus
>

The difference here is that ustrlen() has an argument type specified in
arginfo, while strlen() triggers an error through zend_parse_parameters().
We have practically no arginfo-level type annotations in the standard
library.

Nikita

--047d7bf0ef18b1503c05190b8ce4--