Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86738
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.15.15 as permitted sender)
Message-ID: <5581F37B.4060104@gmx.de>
Date: Thu, 18 Jun 2015 00:23:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Nikita Popov <nikita.ppv@gmail.com>
CC: =?UTF-8?B?Sm9oYW5uZXMgU2NobMO8dGVy?= <johannes@schlueters.de>, 
 Sara Golemon <pollita@php.net>,
 "internals@lists.php.net >> PHP Internals" <internals@lists.php.net>
References: <CADNQb0VcfzJ7U+_2t99vxpdXRSEAeHG98eAdMDB+9EOF0=rAXg@mail.gmail.com>	<00c501d0a773$f84fee90$e8efcbb0$@belski.net>	<CADNQb0WOx8mcrmBdofrZ4CqMJHJrdmb6oQnJTQqxmrHYLq5Xqw@mail.gmail.com>	<557EDF48.9000800@gmx.de>	<1434379932.17693.5.camel@kuechenschabe>	<cuvtna9vg6r4fguhkdbtdra1k66ad4ic11@4ax.com>	<1434400117.17693.10.camel@kuechenschabe>	<4efunalbluqdcrf5h91lmsqtedj5t40i95@4ax.com>	<557F4B64.6040403@gmx.de>	<1434411840.17693.17.camel@kuechenschabe>	<557F6788.9040908@gmx.de>	<1434455919.21120.0.camel@kuechenschabe>	<5580A13F.9040806@gmx.de> <CAF+90c9Ma=VBVD-SzCOJQSU1H2DJhrCugpHCvNTCxe+B7=xFJQ@mail.gmail.com>
In-Reply-To: <CAF+90c9Ma=VBVD-SzCOJQSU1H2DJhrCugpHCvNTCxe+B7=xFJQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] PHP7 releases vs Windows Sources?
From: cmbecker69@gmx.de (Christoph Becker)

Nikita Popov wrote:

> On Wed, Jun 17, 2015 at 12:20 AM, Christoph Becker <cmbecker69@gmx.de>
> wrote:
> 
>> Johannes Schlüter wrote:
>>
>>> On Tue, 2015-06-16 at 02:02 +0200, Christoph Becker wrote:
>>>
>>>> Fair enough.  However, the Windows sources neither contain the generated
>>>> parser files, because they would break linking on Windows, see
>>>> <http://news.php.net/php.internals/86685>.
>>>
>>> This is a bug and has to be addressed.
>>
>> I have investigated further.  The issue is commit b8e2629[1].  I'm
>> certain that Sara had good reasons to mark zendparse() as ZEND_API.
>> However, that breaks building with the generated zend_language_parser
>> files with MSVC, if they have been generated with a somewhat recent
>> bison (2.4.1 still works, 2.7.12 fails), because newer versions declare
>> zendparse() again in .c and .h – without ZEND_API.
>>
>> [1]
>> <
>> https://github.com/php/php-src/commit/b8e262901e56a4d9a6664d348c9878246579239e
> 
> We need some ZEND_API way to invoke the parser from extensions. If it's
> inconvenient to have on zendparse() directly because bison, I'd suggest
> dropping it there and creating a ZEND_API wrapping function.

Thanks!  That would be a simple and clean solution.  I'll make a
respective PR if no one beats me to it.

-- 
Christoph M. Becker