Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86734
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <68262FAD-587B-47FF-B388-3B8551FDCA22@cschneid.com>
References: <68262FAD-587B-47FF-B388-3B8551FDCA22@cschneid.com>
Date: Wed, 17 Jun 2015 18:36:26 +0200
Message-ID: <CAH-PCH7ztj5XS-VNvEWnFMXexk4wOQVQ6k9Zx-i=guTPu8_EHw@mail.gmail.com>
To: Christian Schneider <cschneid@cschneid.com>
Cc: PHP Development <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c25f52d158980518b94a02
Subject: Re: [PHP-DEV] Revisit trailing commas in function call parameters?
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a11c25f52d158980518b94a02
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 17, 2015 at 2:05 PM, Christian Schneider <cschneid@cschneid.com=
>
wrote:

> Hi there,
> now that syntax for variadic functions was added I quickly wanted to ask
> whether allowing trailing commas for function calls could be reconsidered=
.
>
> It is a very small change to the language allowing something like
>         my_variadic_function(
>                 "foo",
>                 "bar",
>                 "qux",
>         );
> which makes adding/removing additional parameters a little easier: No
> comma has to be added/removed from the last line.
>
> Previously this was considered unnecessary but maybe things changed enoug=
h
> to reconsider it? It doesn't involve any BC break and I attached the very
> simple patch needed in the master branch.
>
> If people still consider it more harm- than useful then please don't flam=
e
> me and I'll shut up again :-)
>
> Cheers,
> - Chris
>
>
> diff --git a/Zend/zend_language_parser.y b/Zend/zend_language_parser.y
> index 9612324..f299f3e 100644
> --- a/Zend/zend_language_parser.y
> +++ b/Zend/zend_language_parser.y
> @@ -639,7 +639,7 @@ return_type:
>
>  argument_list:
>                 '(' ')' { $$ =3D zend_ast_create_list(0, ZEND_AST_ARG_LIS=
T);
> }
> -       |       '(' non_empty_argument_list ')' { $$ =3D $2; }
> +       |       '(' non_empty_argument_list possible_comma ')' { $$ =3D $=
2; }
>  ;
>
>  non_empty_argument_list:
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
hi,

just linking to the previous rfc:
https://wiki.php.net/rfc/trailing-comma-function-args and discussion:
http://www.serverphorums.com/read.php?7,655532

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a11c25f52d158980518b94a02--