Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86730
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain cschneid.com from 195.226.6.51 cause and error)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-ID: <68262FAD-587B-47FF-B388-3B8551FDCA22@cschneid.com>
Date: Wed, 17 Jun 2015 14:05:37 +0200
To: PHP Development <internals@lists.php.net>
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Subject: Revisit trailing commas in function call parameters?
From: cschneid@cschneid.com (Christian Schneider)

Hi there,
now that syntax for variadic functions was added I quickly wanted to ask =
whether allowing trailing commas for function calls could be =
reconsidered.

It is a very small change to the language allowing something like
	my_variadic_function(
		"foo",
		"bar",
		"qux",
	);
which makes adding/removing additional parameters a little easier: No =
comma has to be added/removed from the last line.

Previously this was considered unnecessary but maybe things changed =
enough to reconsider it? It doesn't involve any BC break and I attached =
the very simple patch needed in the master branch.

If people still consider it more harm- than useful then please don't =
flame me and I'll shut up again :-)

Cheers,
- Chris


diff --git a/Zend/zend_language_parser.y b/Zend/zend_language_parser.y
index 9612324..f299f3e 100644
--- a/Zend/zend_language_parser.y
+++ b/Zend/zend_language_parser.y
@@ -639,7 +639,7 @@ return_type:
=20
 argument_list:
                '(' ')' { $$ =3D zend_ast_create_list(0, =
ZEND_AST_ARG_LIST); }
-       |       '(' non_empty_argument_list ')' { $$ =3D $2; }
+       |       '(' non_empty_argument_list possible_comma ')' { $$ =3D =
$2; }
 ;
=20
 non_empty_argument_list: