Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86687
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.160.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <FB6FB75C-EB22-49AA-8316-ED59E08F3F5A@icicle.io>
References: <971AB39D-1E20-43E8-9CF1-A7F67E3C14C3@icicle.io>
	<CAGa2bXb8CaJsJorx0HTzSgEeAGXJN7DoW5vi=m+wFiUXNw+tng@mail.gmail.com>
	<556363D3.1040902@gmail.com>
	<12C3389A-AFF5-42CA-8190-E4227309DAED@icicle.io>
	<CAFMT4NppuzY1dhPVcVhFFB-0373AkuB4-dh-mynY0p6R9T76tw@mail.gmail.com>
	<CA+9eiLszbdRS5kKU73HSvvB4zqayS8RKAioX8cJZKqreejKfyQ@mail.gmail.com>
	<016201d0a6bf$96e37dc0$c4aa7940$@belski.net>
	<0A4CC87D-2E54-4202-9AA2-22856F0B6011@icicle.io>
	<CA+9eiLtmDQNCL3YJ9ahJpvkY9YU2RpPR=aPNChi1OSamCZ+Q3w@mail.gmail.com>
	<008701d0a762$4348c320$c9da4960$@belski.net>
	<36F7469F-7D86-43F6-ABC7-9252DF707BFC@icicle.io>
	<CA+9eiLvjXPB99VxcgNZjjCPZ+eDkndx+2c-N+Uyka03uLdZYbA@mail.gmail.com>
	<FB6FB75C-EB22-49AA-8316-ED59E08F3F5A@icicle.io>
Date: Tue, 16 Jun 2015 00:58:17 +0300
Message-ID: <CA+9eiLuL3-vE9+HggO8N1ygqfuMY1+TX-4hGjRdxEmyG4Do3JA@mail.gmail.com>
To: Aaron Piotrowski <aaron@icicle.io>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=485b397dd61328c5840518958e02
Subject: Re: [PHP-DEV] [RFC] Throwable Interface
From: dmitry@zend.com (Dmitry Stogov)

--485b397dd61328c5840518958e02
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I think REGISTER_INTERFACE() macro in zend_interfaces.h is better.
Actually, it's not related to ITERATORs at all.

Thanks. Dmitry.


On Tue, Jun 16, 2015 at 12:48 AM, Aaron Piotrowski <aaron@icicle.io> wrote:

>
> On Jun 15, 2015, at 9:53 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
> On Mon, Jun 15, 2015 at 4:55 PM, Aaron Piotrowski <aaron@icicle.io> wrote=
:
>
>
> On Jun 15, 2015, at 6:56 AM, Anatol Belski <anatol.php@belski.net> wrote:
>
> Would you like me to move zend_ce_throwable to zend_exceptions.h/c or is
> that
> something you=E2=80=99d take care of after the merge?
>
>
> I don't care about this a lot. I just think it's better.
> If you don=E2=80=99t see any problems, please, move the code.
>
>
> Moving the definition of zend_ce_throwable to zend_exceptions.h/c
> requires either:
>
> 1. Moving #define REGISTER_ITERATOR_INTERFACE from
> zend_interfaces.c to zend_interfaces.h so it is available in
> zend_exceptions.c (I could take the opportunity to rename this macro
> to REGISTER_INTERFACE).
>
> 2. Defining a macro in zend_exceptions.c that is identical to
> REGISTER_ITERATOR_INTERFACE.
>
> Which option sounds better?
>
> Aaron Piotrowski
>

--485b397dd61328c5840518958e02--