Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86686
Return-Path: <aaron@icicle.io>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 7211 invoked from network); 15 Jun 2015 21:48:25 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 15 Jun 2015 21:48:25 -0000
Authentication-Results: pb1.pair.com header.from=aaron@icicle.io; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=aaron@icicle.io; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain icicle.io designates 199.38.81.6 as permitted sender)
X-PHP-List-Original-Sender: aaron@icicle.io
X-Host-Fingerprint: 199.38.81.6 mercury.negativeion.net  
Received: from [199.38.81.6] ([199.38.81.6:49562] helo=mercury.negativeion.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id CC/F4-15639-8284F755 for <internals@lists.php.net>; Mon, 15 Jun 2015 17:48:24 -0400
Received: from localhost (localhost [127.0.0.1])
	by mercury.negativeion.net (Postfix) with ESMTP id CA7F726842F3;
	Mon, 15 Jun 2015 17:48:20 -0400 (EDT)
X-Virus-Scanned: amavisd-new at negativeion.net
Received: from mercury.negativeion.net ([127.0.0.1])
	by localhost (mercury.negativeion.net [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id xx8zqHsvtEl8; Mon, 15 Jun 2015 17:48:20 -0400 (EDT)
Received: from macpro.local (unknown [173.225.158.77])
	by mercury.negativeion.net (Postfix) with ESMTPSA id 94A4A26842D7;
	Mon, 15 Jun 2015 17:48:19 -0400 (EDT)
Content-Type: multipart/alternative; boundary="Apple-Mail=_25325AC3-626C-499B-AF13-9E00EB1C270F"
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
In-Reply-To: <CA+9eiLvjXPB99VxcgNZjjCPZ+eDkndx+2c-N+Uyka03uLdZYbA@mail.gmail.com>
Date: Mon, 15 Jun 2015 16:48:18 -0500
Cc: internals@lists.php.net
Message-ID: <FB6FB75C-EB22-49AA-8316-ED59E08F3F5A@icicle.io>
References: <971AB39D-1E20-43E8-9CF1-A7F67E3C14C3@icicle.io> <CAGa2bXb8CaJsJorx0HTzSgEeAGXJN7DoW5vi=m+wFiUXNw+tng@mail.gmail.com> <556363D3.1040902@gmail.com> <12C3389A-AFF5-42CA-8190-E4227309DAED@icicle.io> <CAFMT4NppuzY1dhPVcVhFFB-0373AkuB4-dh-mynY0p6R9T76tw@mail.gmail.com> <CA+9eiLszbdRS5kKU73HSvvB4zqayS8RKAioX8cJZKqreejKfyQ@mail.gmail.com> <016201d0a6bf$96e37dc0$c4aa7940$@belski.net> <0A4CC87D-2E54-4202-9AA2-22856F0B6011@icicle.io> <CA+9eiLtmDQNCL3YJ9ahJpvkY9YU2RpPR=aPNChi1OSamCZ+Q3w@mail.gmail.com> <008701d0a762$4348c320$c9da4960$@belski.net> <36F7469F-7D86-43F6-ABC7-9252DF707BFC@icicle.io> <CA+9eiLvjXPB99VxcgNZjjCPZ+eDkndx+2c-N+Uyka03uLdZYbA@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
X-Mailer: Apple Mail (2.2098)
Subject: Re: [PHP-DEV] [RFC] Throwable Interface
From: aaron@icicle.io (Aaron Piotrowski)

--Apple-Mail=_25325AC3-626C-499B-AF13-9E00EB1C270F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Jun 15, 2015, at 9:53 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>=20
> On Mon, Jun 15, 2015 at 4:55 PM, Aaron Piotrowski <aaron@icicle.io =
<mailto:aaron@icicle.io>> wrote:
>=20
>>=20
>> On Jun 15, 2015, at 6:56 AM, Anatol Belski <anatol.php@belski.net =
<mailto:anatol.php@belski.net>> wrote:
>>=20
>> Would you like me to move zend_ce_throwable to zend_exceptions.h/c or =
is
>> that
>> something you=E2=80=99d take care of after the merge?
>>=20
>=20
> I don't care about this a lot. I just think it's better.
> If you don=E2=80=99t see any problems, please, move the code.
>=20

Moving the definition of zend_ce_throwable to zend_exceptions.h/c
requires either:

1. Moving #define REGISTER_ITERATOR_INTERFACE from
zend_interfaces.c to zend_interfaces.h so it is available in
zend_exceptions.c (I could take the opportunity to rename this macro
to REGISTER_INTERFACE).

2. Defining a macro in zend_exceptions.c that is identical to
REGISTER_ITERATOR_INTERFACE.

Which option sounds better?

Aaron Piotrowski=

--Apple-Mail=_25325AC3-626C-499B-AF13-9E00EB1C270F--