Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86647
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Dmitry Stogov'" <dmitry@zend.com>,
	"'Aaron Piotrowski'" <aaron@icicle.io>
Cc: "'PHP Internals'" <internals@lists.php.net>
References: <971AB39D-1E20-43E8-9CF1-A7F67E3C14C3@icicle.io>	<CAGa2bXb8CaJsJorx0HTzSgEeAGXJN7DoW5vi=m+wFiUXNw+tng@mail.gmail.com>	<556363D3.1040902@gmail.com>	<12C3389A-AFF5-42CA-8190-E4227309DAED@icicle.io>	<CAFMT4NppuzY1dhPVcVhFFB-0373AkuB4-dh-mynY0p6R9T76tw@mail.gmail.com>	<CA+9eiLszbdRS5kKU73HSvvB4zqayS8RKAioX8cJZKqreejKfyQ@mail.gmail.com>	<016201d0a6bf$96e37dc0$c4aa7940$@belski.net>	<0A4CC87D-2E54-4202-9AA2-22856F0B6011@icicle.io> <CA+9eiLtmDQNCL3YJ9ahJpvkY9YU2RpPR=aPNChi1OSamCZ+Q3w@mail.gmail.com>
In-Reply-To: <CA+9eiLtmDQNCL3YJ9ahJpvkY9YU2RpPR=aPNChi1OSamCZ+Q3w@mail.gmail.com>
Date: Mon, 15 Jun 2015 13:56:03 +0200
Message-ID: <008701d0a762$4348c320$c9da4960$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQFtSLKjM4Kf9ceVOz7o+CSYMVJiZgIhwnePAYrvRlYBpwkcHAJFBRC9Ao7iPHsBQ/CyewGDLtqyApwDvJid98k3MA==
Content-Language: en-us
Subject: RE: [PHP-DEV] [RFC] Throwable Interface
From: anatol.php@belski.net ("Anatol Belski")

Hi Dmitry,

> -----Original Message-----
> From: Dmitry Stogov [mailto:dmitry@zend.com]
> Sent: Monday, June 15, 2015 10:53 AM
> To: Aaron Piotrowski
> Cc: Anatol Belski; PHP Internals
> Subject: Re: [PHP-DEV] [RFC] Throwable Interface
>=20
> Hi,
>=20
> I made a quick code review, and I don't see any technical problems in
> implementation.
>=20
> 1) Anyway, I think it's a bad idea to rename "EngineException" (and =
others) into
> "Error"(s).
> This will prevent using class "Error" in applications, and may =
potentially break
> some of them.
> I also don't like renaming in ~440 tests (I didn't review all these =
changes).
>=20
> 2) I think it's better to move "zend_ce_throwable"
> definition/initialization from zend_interfaces.h/c into =
zend_exception.h/c.
> At least, this will allow arg_info reuse. (it's missed now, but should =
be added
> now or in the future).
>=20
> 3) In ext/simplexml/tests/SimpleXMLElement_xpath_3.phpt =
EngineExcpetion is
> not renamed into Error.
>=20
Thanks for the review. I've also tested the branch which has today's =
master merged in, by now it doesn't show any functional regression.

Actually I part your first concern about Error. Spent some time phishing =
for "class Error" on github and found three apps doing this without =
namespace. But that's from 100 search result pages. And those three apps =
are forked zero to 1 times, so pretty much low usage. This will likely =
break more in the world, we hardly know.

The current RFC can't be changed while in voting. But how it looks like, =
the principle of the Trowable RFC is something everyone agrees on. Maybe =
do another RFC in parallel for better names? Still I'd stand for taking =
it into alpha2 - if we want to have it, better to arrange it in a way =
that it doesn't cause unnecessary delays in the release process.

Regards

Anatol


=20