Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86645
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.160.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <0A4CC87D-2E54-4202-9AA2-22856F0B6011@icicle.io>
References: <971AB39D-1E20-43E8-9CF1-A7F67E3C14C3@icicle.io>
	<CAGa2bXb8CaJsJorx0HTzSgEeAGXJN7DoW5vi=m+wFiUXNw+tng@mail.gmail.com>
	<556363D3.1040902@gmail.com>
	<12C3389A-AFF5-42CA-8190-E4227309DAED@icicle.io>
	<CAFMT4NppuzY1dhPVcVhFFB-0373AkuB4-dh-mynY0p6R9T76tw@mail.gmail.com>
	<CA+9eiLszbdRS5kKU73HSvvB4zqayS8RKAioX8cJZKqreejKfyQ@mail.gmail.com>
	<016201d0a6bf$96e37dc0$c4aa7940$@belski.net>
	<0A4CC87D-2E54-4202-9AA2-22856F0B6011@icicle.io>
Date: Mon, 15 Jun 2015 11:53:21 +0300
Message-ID: <CA+9eiLtmDQNCL3YJ9ahJpvkY9YU2RpPR=aPNChi1OSamCZ+Q3w@mail.gmail.com>
To: Aaron Piotrowski <aaron@icicle.io>
Cc: Anatol Belski <anatol.php@belski.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=485b397dd613fe135f05188a96ca
Subject: Re: [PHP-DEV] [RFC] Throwable Interface
From: dmitry@zend.com (Dmitry Stogov)

--485b397dd613fe135f05188a96ca
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

I made a quick code review, and I don't see any technical problems in
implementation.

1) Anyway, I think it's a bad idea to rename "EngineException" (and others)
into "Error"(s).
This will prevent using class "Error" in applications, and may potentially
break some of them.
I also don't like renaming in ~440 tests (I didn't review all these
changes).

2) I think it's better to move "zend_ce_throwable"
definition/initialization from zend_interfaces.h/c into zend_exception.h/c.
At least, this will allow arg_info reuse. (it's missed now, but should be
added now or in the future).

3) In ext/simplexml/tests/SimpleXMLElement_xpath_3.phpt EngineExcpetion is
not renamed into Error.

Thanks. Dmitry.





On Sun, Jun 14, 2015 at 8:24 PM, Aaron Piotrowski <aaron@icicle.io> wrote:

>
> > On Jun 14, 2015, at 11:31 AM, Anatol Belski <anatol.php@belski.net>
> wrote:
> >
> > Hi Dmitry,
> >
> >
> >
> > I would go by accepting this. Furthermore =E2=80=93 if you feel that th=
e
> implementation is stable enough and does not BC, I would suggest to have =
it
> already in the alpha2.
> >
> >
> >
> > As there seems to be at all no resistance in the votes (no even single
> =E2=80=9Cno=E2=80=9D voter yet),  nor strong objection here on the lists.=
 The minimal
> voting period is 1 week, so theoretically if it were ended on Wed  (the
> voting RFC doesn=E2=80=99t disallow this) =E2=80=93 there were still some=
 time to do
> extensive testing and fixes. Alpha2 is the time where a) a lot of users
> will be able to test it and b) it still can be reverted in the worst case=
.
> >
> >
> >
> > What do you think?
> >
> >
> >
> > Regards
> >
> >
> >
> > Anatol
> >
>
> I will have some time to resolve the merge conflicts later today, so I
> will be happy to take care of that.
>
> Regards,
> Aaron Piotrowski
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--485b397dd613fe135f05188a96ca--