Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86596
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Christoph Becker'" <cmbecker69@gmx.de>,
	<internals@lists.php.net>
References: <5578B943.1070006@gmx.de> <5578BCF7.1050200@lerdorf.com> <022601d0a3df$d0ccedb0$7266c910$@belski.net> <55796AF3.1040205@gmx.de>
In-Reply-To: <55796AF3.1040205@gmx.de>
Date: Thu, 11 Jun 2015 14:01:56 +0200
Message-ID: <02ca01d0a43e$6c6bb4f0$45431ed0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQFsGmKyhtwMbkZmdgSlE7heOfyBEAEcmhriAcZgkYwCbSne0J5Fv6aQ
Content-Language: en-us
Subject: RE: [PHP-DEV] Request for php-src karma
From: anatol.php@belski.net ("Anatol Belski")

Hi Christoph,

> -----Original Message-----
> From: Christoph Becker [mailto:cmbecker69@gmx.de]
> Sent: Thursday, June 11, 2015 1:03 PM
> To: Anatol Belski; internals@lists.php.net
> Subject: Re: [PHP-DEV] Request for php-src karma
>=20
> Anatol Belski wrote:
>=20
> > Christoph, please don't forget to note the changes in the NEWS =
and/or
> > UPGRADING where appropriate. Also don't forget to check the lower
> > branches where your fixes could be profitable.
>=20
> Thanks for the hints.  As I understand it, I should inform the release =
managers
> about changes in the respective branches.[1][2]  What is the best way =
to do so?
>=20
> [1] <https://wiki.php.net/vcs/gitworkflow?s[]=3Drelease&s[]=3Dmanager>
> [2] <https://bugs.php.net/bug.php?id=3D68812#1433889583> (stas' =
comment)
>=20
Please note also that there is a number of README files in the php-src =
dir, like this one =
http://git.php.net/?p=3Dphp-src.git;a=3Dblob;f=3DREADME.GIT-RULES . In =
general, if you fix a bug and it's worth it to mention, you just push a =
patch and add note into the NEWS. If in doubt, better to ask the RM =
whether the patch is ok for that particular branch, of course.

Pushing to the 5.4 branch is another story as only security fixes go in =
there, so it has to be cleared out explicitly. The same will apply to =
any other branch in security mode later, fe 5.5 which active development =
period ends soon. Also as far as I see, the patch from the ticket you =
link was not merged up as in accordance to the git workflow.

The NEWS file has to be updated in all the active branches but master, =
usually. Otherwise, if a fix in master only - so only NEWS in master. As =
we now have no explicit PHP-7.0 branch, NEWS should be updated in master =
as well until PHP-5.4 is EOL.

Regards

Anatol