Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86554
Return-Path: <php@golemon.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 29288 invoked from network); 10 Jun 2015 14:50:31 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 10 Jun 2015 14:50:31 -0000
Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail
Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.215.41 as permitted sender)
X-PHP-List-Original-Sender: php@golemon.com
X-Host-Fingerprint: 209.85.215.41 mail-la0-f41.google.com  
Received: from [209.85.215.41] ([209.85.215.41:33648] helo=mail-la0-f41.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 70/82-15306-5BE48755 for <internals@lists.php.net>; Wed, 10 Jun 2015 10:50:30 -0400
Received: by labpy14 with SMTP id py14so34942079lab.0
        for <internals@lists.php.net>; Wed, 10 Jun 2015 07:50:27 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:sender:in-reply-to:references:date
         :message-id:subject:from:to:cc:content-type;
        bh=Iw0ZeFPjeNlucCngSDVR0GBGvtCnWWabikhqRZNlkbQ=;
        b=DuerAB4/icMcWeVoTPBKW4ao7A1yswT7abyBsU8EIdMNWRl8cZBmBEKE4C9/gCJt+n
         rpz5NTeIaH4QTAGJKZRID1UkZBsVOdFJRSIk18sUSjw3V0JQIAReAypIshsxoVvBJq4b
         +adCAO3EYgr86IHXl7X0gy2lVXC0V/o1haRxdBZHePG7H/VsaOZM7hCpttSkQaJT4PHR
         KCzogn9eY1yrF2nDhvphYS490tV1Sp/IacxuaQSNJNjWFj8x8d+Uyibf4hLEaT2ZzTAx
         8+SMwGsH4B6cZHumjYsVUL9wHiAbKSLmXUfoyL20Bkh1IfrCt0tXH7wGytNWwFoZOQvK
         KAaw==
X-Gm-Message-State: ALoCoQmOvbNIMNasc7I3FXWpTXlrk6f2NRzVFdhDe12VAX/SYxJB1CAfTULTgZkaITLqKVxVCCn+
MIME-Version: 1.0
X-Received: by 10.152.42.200 with SMTP id q8mr4293292lal.53.1433947826178;
 Wed, 10 Jun 2015 07:50:26 -0700 (PDT)
Sender: php@golemon.com
Received: by 10.112.11.134 with HTTP; Wed, 10 Jun 2015 07:50:26 -0700 (PDT)
X-Originating-IP: [73.189.247.124]
In-Reply-To: <CAESVnVpBKS_0FMr-hXMWUsXURb=NbrfYXGLGVnnPH6y+byR24g@mail.gmail.com>
References: <CAESVnVr6oyAOCjWRWp7MGio_JNuUryPm=HKeY=fDgKRBcMXJ=Q@mail.gmail.com>
	<55513AA4.7010706@gmail.com>
	<579127CDC1B54040BEEFD4564A6F78B7@pc1>
	<CAESVnVpDXmLB-Gd_9HTyrdcnuS8g27Gezwgodb1CVLCVo0u2tg@mail.gmail.com>
	<1FAF88D0E2DE433FA299B4FAF7120880@pc1>
	<CAESVnVpBKS_0FMr-hXMWUsXURb=NbrfYXGLGVnnPH6y+byR24g@mail.gmail.com>
Date: Wed, 10 Jun 2015 07:50:26 -0700
X-Google-Sender-Auth: u8_WHGIn6lWK70UjwQ23RKraQlM
Message-ID: <CAESVnVpkrthvKq1GCYPNH-4ujPRH-RUSqEMyVhY3X-O-kUN24g@mail.gmail.com>
To: Matt Wilmas <php_lists@realplain.com>
Cc: Dmitry Stogov <dmitry@php.net>, Stanislav Malyshev <smalyshev@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Undefined variables undefined order
From: pollita@php.net (Sara Golemon)

On Wed, Jun 10, 2015 at 7:42 AM, Sara Golemon <pollita@php.net> wrote:
> Dmitry, what's the reasoning behind this diff in the first place?
> Doesn't the compiler fold (<const-string> . <const-string>) already
> anyhow?  How would we wind up with CONCAT_CONST_CONST at runtime?
>
Derp.  Looked again, and it's (const *OR* string) && (const *OR*
string).  I read those as ANDs initially.

But now I'm confused again, because that makes it look like we can
reach this with an expression like "1 . 2" 1 and 2 are consts, but not
strings, so then we get to:

  zend_string *op1_str = Z_STR_P(op1);

Which will lead to op1_str pointing at 0x00000001 and a segfault.

What am I missing here?

-Sara