Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86539
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.216.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4NppuzY1dhPVcVhFFB-0373AkuB4-dh-mynY0p6R9T76tw@mail.gmail.com>
References: <971AB39D-1E20-43E8-9CF1-A7F67E3C14C3@icicle.io>
	<CAGa2bXb8CaJsJorx0HTzSgEeAGXJN7DoW5vi=m+wFiUXNw+tng@mail.gmail.com>
	<556363D3.1040902@gmail.com>
	<12C3389A-AFF5-42CA-8190-E4227309DAED@icicle.io>
	<CAFMT4NppuzY1dhPVcVhFFB-0373AkuB4-dh-mynY0p6R9T76tw@mail.gmail.com>
Date: Wed, 10 Jun 2015 10:37:00 +0300
Message-ID: <CA+9eiLszbdRS5kKU73HSvvB4zqayS8RKAioX8cJZKqreejKfyQ@mail.gmail.com>
To: Levi Morrison <levim@php.net>, Aaron Piotrowski <aaron@icicle.io>, Nikita Popov <nikita.ppv@gmail.com>
Cc: internals <internals@lists.php.net>, Anatol Belski <ab@php.net>, 
	Kalle Sommer Nielsen <kalle@php.net>
Content-Type: multipart/alternative; boundary=bcaec5486476b9fa0d051824f0a4
Subject: Re: [PHP-DEV] [RFC] Throwable Interface
From: dmitry@zend.com (Dmitry Stogov)

--bcaec5486476b9fa0d051824f0a4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 9, 2015 at 9:13 PM, Levi Morrison <levim@php.net> wrote:

> On Tue, Jun 9, 2015 at 11:40 AM, Aaron Piotrowski <aaron@icicle.io> wrote=
:
> > Does anyone have any questions, comments, or concerns about the
> Throwable Interface RFC?
> >
> > http://wiki.php.net/rfc/throwable-interface
> >
> > The proposed exception hierarchy:
> >
> > interface Throwable
> >         =E2=8A=A2 Exception implements Throwable
> >         =E2=88=9F Error implements Throwable (replaces EngineException)
> >                 =E2=8A=A2 TypeError (replaces TypeException)
> >                 =E2=88=9F ParseError (replaces ParseException)
> >
> > I=E2=80=99d like to complete a vote before too many alpha releases are =
made.
> >
> > I=E2=80=99ll be happy to resolve the merge conflicts in the PR if the v=
ote
> passes.
>
> My only objections have already been raised, but I'll reiterate them
> briefly:
>
>   1. Having both Error and Exception makes little sense, especially
> since we have historically used error to refer to an error that wasn't
> an exception (something that triggered the error handler).
>   2. The name "Error" is going to have a fairly high collision rate
> with user code.
>

I also like EngineException more than Error.


>   3. I think they should all use Exception as the root instead having
> a new root with multiple children (and yes, I am aware of the impact
> of this, and it has already been discussed on this list).
>

This done on purpose. To prevent catching of new exceptions by old PHP code=
.

If we won't accept this now (before 7.0 release), it would make more
troubles in the future.
I didn't make deep code review, and don't know all possible consequences.
Anyway, I would make a chance to accept this now or never.

RM, your thoughts?
In case we decide to vote for this RFC, I'll make code review and will help
with possible problems.

Thanks. Dmitry.



>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--bcaec5486476b9fa0d051824f0a4--