Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86495
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.169 as permitted sender)
Message-ID: <5571697F.1080502@gmail.com>
Date: Fri, 05 Jun 2015 10:18:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAF+90c_Ld1BAaj2kd+hhdNkcbj6Mar2EZSYPJaSFWqmV_tb=Xw@mail.gmail.com> <CABBJUpetNuWYxiA8Zx9jDdqEW3iAjct5jzMzwCN-1h33cnOV5g@mail.gmail.com> <loom.20150605T074637-152@post.gmane.org>
In-Reply-To: <loom.20150605T074637-152@post.gmane.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Argument unpacking
From: rowan.collins@gmail.com (Rowan Collins)

Yo-An Lin wrote on 05/06/2015 06:51:
> Laruence <laruence <at> php.net> writes:
>
>> On Fri, Aug 30, 2013 at 11:23 PM, Nikita Popov <nikita.ppv <at> gmail.com>
>> wrote:
>>> Hi internals!
>>>
>>> This RFC proposes to add a syntax for argument unpacking:
>>>
>>>      https://wiki.php.net/rfc/argument_unpacking
>>>
>>> Basically, this is the "complement" of the variadics RFC: It is not about
>>> declaring variadic functions, but about calling them.
>>>
>>> The syntax it introduces looks as follows:
>>>
>>>      $db->query($query, ...$params);
>> seems so weird and ugly..
>>
>> -1
> I totally agree.. the syntax design doesn't look quiet right.  it isn't
> readable and ugly.
>
> Since it's unpacking the arguments from the caller, the "..." should be put
> after the $params. e.g.
>
>      $db->query($query, $params...);
>
> the above approach is also used in Go.

Not sure why you've picked this up now, but the mail you're replying to 
is from nearly two years ago, and the syntax in question was accepted, 
and released as part of PHP 5.6.0 in August 2014. The documentation can 
be found here: 
http://php.net/functions.arguments#functions.variable-arg-list

So it's far too late to change the syntax, even if we had a better 
reason than "it looks nicer to me with the ... the other side of the name".

Regards,
-- 
Rowan Collins
[IMSoP]