Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86425
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.175 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <5566BE78.20605@gmail.com>
References: <5566BE78.20605@gmail.com>
Date: Thu, 28 May 2015 11:38:52 -0600
Message-ID: <CAFMT4Np-CCs=_i49BboeVOkPGYfQPUeTc4nEpy14FMgZdba=Zw@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] return/parameter types for magic functions
From: levim@php.net (Levi Morrison)

On Thu, May 28, 2015 at 1:06 AM, Stanislav Malyshev <smalyshev@gmail.com> wrote:
> Hi!
>
> Since we now allow defining return value types for functions, one can
> also create definition for magic functions that make no sense, such as
> __toString() : float or __isset() : Closure. I think we should restrict
> such definitions - either to types that makes sense or in case of
> methods that aren't supposed to return anything useful, completely. We
> already do this for ctors, dtors and __clone but not consistently for
> other magics. Also some values for parameter types make no sense.

My original patch for return types did not allow return types for
ctors, dtors, and __clone. It seems you did not preserve this? In any
case no RFC is needed because this was outlined in the RFC:
https://wiki.php.net/rfc/return_types#methods_which_cannot_declare_return_types

The only one that should allow anything for now is __toString which
would be permitted to declare a return type of string.