Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86405
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Xinchen Hui'" <laruence@php.net>,
	"'Hannes Magnusson'" <hannes.magnusson@gmail.com>
Cc: "'Internals'" <internals@lists.php.net>
References: <063f01d09881$2bbf12d0$833d3870$@belski.net> <CADNQb0VVm+W4+PfzoJ6Y4Qyy6Hdnb-s4O0S9Qf5dFdV3x2DdcA@mail.gmail.com> <CABBJUpdqBGb9qW3pjNBDDhs7pg9Oai=B6WsUhJkOJdsQfv-zDA@mail.gmail.com>
In-Reply-To: <CABBJUpdqBGb9qW3pjNBDDhs7pg9Oai=B6WsUhJkOJdsQfv-zDA@mail.gmail.com>
Date: Wed, 27 May 2015 18:10:16 +0200
Message-ID: <065a01d09897$a158a810$e409f830$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIaizz8RdK2mxf+r6vVIIzajk2BSgGm271jAXSunO6c4ztLcA==
Content-Language: en-us
Subject: RE: [PHP-DEV] Pull request labels handling
From: anatol.php@belski.net ("Anatol Belski")

Hi,

> -----Original Message-----
> From: Xinchen Hui [mailto:laruence@php.net]
> Sent: Wednesday, May 27, 2015 5:25 PM
> To: Hannes Magnusson
> Cc: Anatol Belski; Internals
> Subject: Re: [PHP-DEV] Pull request labels handling
>=20
> On Wed, May 27, 2015 at 10:27 PM, Hannes Magnusson
> <hannes.magnusson@gmail.com> wrote:
> > On Wed, May 27, 2015 at 6:29 AM, Anatol Belski =
<anatol.php@belski.net>
> wrote:
> >> Hi,
> >>
> >> the PRs on github are already being labeled. Multiple labels are =
possible.
> >> However the github ACLs lack on granularity
> >> =
https://help.github.com/articles/permission-levels-for-an-organizatio
> >> n-repos itory/ . Due to that, while being a useful feature, =
labeling
> >> is only available for project admins or alike. Now with PHP7 such
> >> labeling becomes probably even more sense as we'll need to handle =
BC
> >> breaks and other situations which would need more testing and care.
> >> So the amount of work to evaluate and review PRs will grow while =
the
> >> "work team" probably not.
> >
> >
> > I don't have time to work on qa.php.net/pulls and add such feature, =
so
> > I gave Xinchen and Nikita admin rights for the organization as a
> > workaround. Stas was already an admin.
> >
> > We did mention that if labelling is supposed to be integral part of
> > the workflow this must be available for the normal karma holder and
> > therefore needs to be integrated somehow.
> Github expose such apis already
> https://developer.github.com/v3/issues/#edit-an-issue
>=20
> so I think it's not very difficult to add such features to =
qa.php.net/pulls now.
>=20
> any volunteer ?  if no, I can work on it this weekend... hope I didn't =
forget
> my experience on jquery :)
>=20
>=20
I can take this, maybe to qa.php.net/pulls first were easier. Then =
bugs.php.net if it's found useful useful. Will need to refresh the =
jquery status as well :)=20

Regards

Anatol