Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:86404 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 16208 invoked from network); 27 May 2015 16:03:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 May 2015 16:03:07 -0000 Authentication-Results: pb1.pair.com smtp.mail=anatol.php@belski.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=anatol.php@belski.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error) X-PHP-List-Original-Sender: anatol.php@belski.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:42872] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AD/83-26265-8BAE5655 for ; Wed, 27 May 2015 12:03:05 -0400 Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006) id A614C6D209A; Wed, 27 May 2015 18:03:01 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on h1123647.serverkompetenz.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.5 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable version=3.3.2 Received: from w520phpdev (p579F3035.dip0.t-ipconnect.de [87.159.48.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by h1123647.serverkompetenz.net (Postfix) with ESMTPSA id E69316D2044; Wed, 27 May 2015 18:02:59 +0200 (CEST) To: "'Hannes Magnusson'" Cc: "'Internals'" References: <063f01d09881$2bbf12d0$833d3870$@belski.net> In-Reply-To: Date: Wed, 27 May 2015 18:02:52 +0200 Message-ID: <065801d09896$987d01b0$c9770510$@belski.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQIaizz8RdK2mxf+r6vVIIzajk2BSgGm271jnO7fAgA= Content-Language: en-us Subject: RE: [PHP-DEV] Pull request labels handling From: anatol.php@belski.net ("Anatol Belski") Hi, > -----Original Message----- > From: Hannes Magnusson [mailto:hannes.magnusson@gmail.com] > Sent: Wednesday, May 27, 2015 4:27 PM > To: Anatol Belski > Cc: Internals > Subject: Re: [PHP-DEV] Pull request labels handling >=20 > On Wed, May 27, 2015 at 6:29 AM, Anatol Belski > wrote: > > Hi, > > > > the PRs on github are already being labeled. Multiple labels are = possible. > > However the github ACLs lack on granularity > > = https://help.github.com/articles/permission-levels-for-an-organization > > -repos itory/ . Due to that, while being a useful feature, labeling = is > > only available for project admins or alike. Now with PHP7 such > > labeling becomes probably even more sense as we'll need to handle BC > > breaks and other situations which would need more testing and care. = So > > the amount of work to evaluate and review PRs will grow while the > > "work team" probably not. >=20 >=20 > I don't have time to work on qa.php.net/pulls and add such feature, so = I > gave Xinchen and Nikita admin rights for the organization as a = workaround. > Stas was already an admin. >=20 > We did mention that if labelling is supposed to be integral part of = the > workflow this must be available for the normal karma holder and = therefore > needs to be integrated somehow. >=20 So seems the idea is even older :) The question only whether people find = it useful and the feature is going to bring something. That's what we = hope it would. Regards Anatol