Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:86403
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CADNQb0VVm+W4+PfzoJ6Y4Qyy6Hdnb-s4O0S9Qf5dFdV3x2DdcA@mail.gmail.com>
References: <063f01d09881$2bbf12d0$833d3870$@belski.net> <CADNQb0VVm+W4+PfzoJ6Y4Qyy6Hdnb-s4O0S9Qf5dFdV3x2DdcA@mail.gmail.com>
Date: Wed, 27 May 2015 23:24:52 +0800
Message-ID: <CABBJUpdqBGb9qW3pjNBDDhs7pg9Oai=B6WsUhJkOJdsQfv-zDA@mail.gmail.com>
To: Hannes Magnusson <hannes.magnusson@gmail.com>
Cc: Anatol Belski <anatol.php@belski.net>, Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Pull request labels handling
From: laruence@php.net (Xinchen Hui)

On Wed, May 27, 2015 at 10:27 PM, Hannes Magnusson
<hannes.magnusson@gmail.com> wrote:
> On Wed, May 27, 2015 at 6:29 AM, Anatol Belski <anatol.php@belski.net> wrote:
>> Hi,
>>
>> the PRs on github are already being labeled. Multiple labels are possible.
>> However the github ACLs lack on granularity
>> https://help.github.com/articles/permission-levels-for-an-organization-repos
>> itory/ . Due to that, while being a useful feature, labeling is only
>> available for project admins or alike. Now with PHP7 such labeling becomes
>> probably even more sense as we'll need to handle BC breaks and other
>> situations which would need more testing and care. So the amount of work to
>> evaluate and review PRs will grow while the "work team" probably not.
>
>
> I don't have time to work on qa.php.net/pulls and add such feature, so
> I gave Xinchen and Nikita admin rights for the organization as a
> workaround. Stas was already an admin.
>
> We did mention that if labelling is supposed to be integral part of
> the workflow this must be available for the normal karma holder and
> therefore needs to be integrated somehow.
Github expose such apis already
https://developer.github.com/v3/issues/#edit-an-issue

so I think it's not very difficult to add such features to qa.php.net/pulls now.

any volunteer ?  if no, I can work on it this weekend... hope I didn't
forget my experience on jquery :)


thanks
>
> -Hannes
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/